Skip to content

Commit 7c2efb3

Browse files
committed
fix(preferences): only show smart-filter hint when enabling it
Toggling Smart Filter off also fired the "smart filter loosely matches the domain name" notification. Show it only when the toggle is turned on. Refs Authenticator-Extension#1282
1 parent 8ce1acb commit 7c2efb3

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

src/components/Popup/PreferencesPage.vue

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,13 @@ export default Vue.extend({
8989
},
9090
set(smartFilter: boolean) {
9191
this.$store.commit("menu/setSmartFilter", smartFilter);
92-
this.$store.commit(
93-
"notification/alert",
94-
this.i18n.activate_auto_filter
95-
);
92+
// only explain smart filter when turning it on, not off (#1282)
93+
if (smartFilter) {
94+
this.$store.commit(
95+
"notification/alert",
96+
this.i18n.activate_auto_filter
97+
);
98+
}
9699
},
97100
},
98101
enableContextMenu: {

0 commit comments

Comments
 (0)