Add package review metadata command

Author: olwang

Cargo.lock

@@ -15,5 +15,6 @@ path = "src/main.rs"
 [dependencies]
 serde = { version = "1", features = ["derive"] }
 serde_json = "1"
+toml = "0.8"
 
 [dev-dependencies]

Cargo.toml

@@ -387,6 +387,7 @@ rustc diagnostic remapping through source maps
 zero-argument `fn main() -> Unit` and `fn main() -> Result<Unit, E>` package harnesses for runnable Rust output
 core `.rssi` interface signatures
 HIR builtin signatures parsed from `.rssi` interface sources instead of a hand-written Rust table
+initial `rsspkg.toml` package review metadata
 CI gates for formatting, linting, tests, and generated Rust fixtures
 golden tests for Rust lowering and source-map shape
 ```
@@ -404,6 +405,7 @@ rss lint [--json] [--core|--no-core] [--interface <file.rssi> ...] <file.rss>
 rss fmt <file.rss>
 rss review [--json] --diff <old.rss> <new.rss>
 rss review [--json] --map <file-or-directory>
+rss package review [--json] <package-directory>
 rss lower --rust <file.rss>
 rss lower --rust <file.rss> --out-dir <directory>
 rss run [--json] <file.rss>
@@ -419,6 +421,8 @@ rss verify-rust [--json] <file.rss> --out-dir <directory>
 
 `rss review --map` checks inputs before emitting a map. Files with frontend errors produce diagnostics instead of potentially misleading review classifications.
 
+`rss package review` reads `rsspkg.toml`, loads declared interface/source roots, and emits conservative package review metadata. It treats `.rssi` files as the public semantic contract, reports package features separately from file-level `features:`, and raises risk for native Rust wrappers, build scripts, proc macros, unsafe policy, external links, frontend diagnostics, and unknown review-map regions.
+
 If a lowered package contains `fn main() -> Unit` or `fn main() -> Result<Unit, E>`, `rss lower --rust --out-dir` also emits a Rust `src/main.rs` harness. `rss run <file.rss>` uses the same lowering path, writes a temporary Rust package, and delegates execution to `cargo run`. Use `rss run <file.rss> --out-dir <directory>` to keep the generated Rust package for inspection. Frontend and RSScript runtime diagnostics from `rss run` support `--json`; successful program output remains the program's own stdout.
 
 `rss verify-rust <file.rss> --out-dir <directory>` keeps the generated package used for backend checking, including `rsscript-source-map.json`, so unmappable rustc diagnostics can be inspected against the generated Rust.

README.md

@@ -71,7 +71,8 @@ pub mod code {
     pub const REVIEW_FUNCTION_KIND_CHANGED: &str = "RSR014";
 }
 
-#[derive(Debug, Clone, PartialEq, Eq)]
+#[derive(Debug, Clone, PartialEq, Eq, Serialize)]
+#[serde(rename_all = "lowercase")]
 pub enum Severity {
     Error,
     Warning,
@@ -105,7 +106,7 @@ pub struct Fix {
     pub applicability: String,
 }
 
-#[derive(Debug, Clone, PartialEq, Eq)]
+#[derive(Debug, Clone, PartialEq, Eq, Serialize)]
 pub struct Diagnostic {
     pub code: String,
     pub severity: Severity,

src/diagnostic.rs

@@ -5,6 +5,7 @@ mod hir;
 mod interfaces;
 mod lexer;
 mod lint;
+mod package;
 mod review;
 mod rust_lower;
 pub mod syntax;
@@ -17,6 +18,11 @@ pub use diagnostic::{
     format_diagnostic_explanation, format_diagnostics_human, format_diagnostics_json,
 };
 pub use lint::lint_source;
+pub use package::{
+    PackageIdentity, PackageNativeRustReview, PackageReview, PackageReviewFile,
+    PackageReviewFileKind, PackageReviewSummary, PackageRisk, format_package_review_human,
+    format_package_review_json, review_package_dir,
+};
 pub use review::{
     ReviewFinding, ReviewFix, ReviewMap, ReviewMapCategorySummary, ReviewMapClassification,
     ReviewMapFile, ReviewMapFileRisk, ReviewMapRegion, ReviewMapSummary, ReviewRisk,

src/lib.rs

@@ -7,11 +7,11 @@ use std::time::{SystemTime, UNIX_EPOCH};
 use rsscript::{
     Diagnostic, analyze_source, analyze_source_with_interfaces, check_generated_rust_package,
     core_interfaces, explain_diagnostic_code, format_diagnostic_explanation,
-    format_diagnostics_human, format_diagnostics_json, format_review_human, format_review_json,
-    format_review_map_human, format_review_map_json, lint_source, lower_source_to_rust,
-    lower_source_to_rust_package, parse_runtime_diagnostics, parse_source_map_json,
-    remap_rustc_diagnostic_json_lines, review_map_sources, review_sources,
-    write_generated_rust_package,
+    format_diagnostics_human, format_diagnostics_json, format_package_review_human,
+    format_package_review_json, format_review_human, format_review_json, format_review_map_human,
+    format_review_map_json, lint_source, lower_source_to_rust, lower_source_to_rust_package,
+    parse_runtime_diagnostics, parse_source_map_json, remap_rustc_diagnostic_json_lines,
+    review_map_sources, review_package_dir, review_sources, write_generated_rust_package,
 };
 
 fn main() -> ExitCode {
@@ -26,6 +26,7 @@ fn main() -> ExitCode {
         "lint" => run_lint(&args[2..]),
         "fmt" => run_fmt(&args[2..]),
         "review" => run_review(&args[2..]),
+        "package" | "pkg" => run_package(&args[2..]),
         "lower" => run_lower(&args[2..]),
         "run" => run_generated_rust(&args[2..]),
         "remap-rustc" => run_remap_rustc(&args[2..]),
@@ -37,6 +38,16 @@ fn main() -> ExitCode {
     }
 }
 
+fn run_package(args: &[String]) -> ExitCode {
+    match parse_package_args(args) {
+        PackageCommand::Review { json, path } => run_package_review(json, path),
+        PackageCommand::Invalid => {
+            print_usage();
+            ExitCode::from(2)
+        }
+    }
+}
+
 fn run_lint(args: &[String]) -> ExitCode {
     let options = parse_check_args(args);
     let Some(path) = options.path else {
@@ -766,6 +777,32 @@ enum ReviewCommand<'a> {
     Invalid,
 }
 
+enum PackageCommand<'a> {
+    Review { json: bool, path: &'a str },
+    Invalid,
+}
+
+fn parse_package_args(args: &[String]) -> PackageCommand<'_> {
+    let mut json = false;
+    let mut command = None;
+    let mut paths = Vec::new();
+
+    for arg in args {
+        if arg == "--json" {
+            json = true;
+        } else if arg == "review" {
+            command = Some(arg.as_str());
+        } else {
+            paths.push(arg.as_str());
+        }
+    }
+
+    match (command, paths.as_slice()) {
+        (Some("review"), [path]) => PackageCommand::Review { json, path },
+        _ => PackageCommand::Invalid,
+    }
+}
+
 fn parse_review_args(args: &[String]) -> ReviewCommand<'_> {
     let mut json = false;
     let mut command = None;
@@ -868,6 +905,35 @@ fn run_review_map(json: bool, path: &str) -> ExitCode {
     ExitCode::SUCCESS
 }
 
+fn run_package_review(json: bool, path: &str) -> ExitCode {
+    let review = match review_package_dir(Path::new(path)) {
+        Ok(review) => review,
+        Err(error) => {
+            eprintln!("{error}");
+            return ExitCode::from(2);
+        }
+    };
+
+    if json {
+        println!("{}", format_package_review_json(&review));
+    } else {
+        print!("{}", format_package_review_human(&review));
+        if !review.diagnostics.is_empty() {
+            print!("{}", format_diagnostics_human(&review.diagnostics));
+        }
+    }
+
+    if review
+        .diagnostics
+        .iter()
+        .any(|diagnostic| diagnostic.severity.is_error())
+    {
+        ExitCode::from(1)
+    } else {
+        ExitCode::SUCCESS
+    }
+}
+
 struct ReviewMapSource {
     path: String,
     contents: String,
@@ -944,4 +1010,5 @@ fn print_usage() {
     eprintln!("  rsscript verify-rust [--json] <file.rss> --out-dir <directory>");
     eprintln!("  rsscript review [--json] --diff <old.rss> <new.rss>");
     eprintln!("  rsscript review [--json] --map <file-or-directory>");
+    eprintln!("  rsscript package review [--json] <package-directory>");
 }