Custom "Not Found" callback.

[AdriaanBoshoff]

Is it possible to add a custom callback for when a endpoint does not exist? Currently it only returns "Not Found" and I wish to add more logic to this.

EDIT:

THorse.All('*',
    procedure(Req: THorseRequest; Res: THorseResponse; Next: TProc)
    begin
      Res.Send('Custom Not Found');
    end);

This only works if a path is provided such as: http://localhost:8080/test/ but when it's just http://localhost:8080/ then it no longer works.

[daviddev16]

For the horse's route tree http://localhost:8080/test/ and http://localhost:8080/test are the same.

It would be nice to have a configuration that would allow us to make horse differentiate between "/test/" and "/test". Spring MVC has this feature.

...
 public void configurePathMatch(PathMatchConfigurer configurer) {
      configurer.setUseTrailingSlashMatch(false);
  }
...

@AdriaanBoshoff Would this solution work for you?

I'll work on it.

[viniciussanchez]

When you're ready, please send us a pull request.

[AdriaanBoshoff]

For the horse's route tree http://localhost:8080/test/ and http://localhost:8080/test are the same.

It would be nice to have a configuration that would allow us to make horse differentiate between "/test/" and "/test". Spring MVC has this feature.

...
public void configurePathMatch(PathMatchConfigurer configurer) {
configurer.setUseTrailingSlashMatch(false);
}
...
@AdriaanBoshoff Would this solution work for you?

I'll work on it.

Its not about the path. Its that the current solution for adding a customer not found logic is not working with the root uri. Only works when adding paths.

[daviddev16]

Its not about the path. Its that the current solution for adding a customer not found logic is not working with the root uri. Only works when adding paths.

Can you provide a code snippet that illustrates what you're trying to achieve?

[AdriaanBoshoff]

Its not about the path. Its that the current solution for adding a customer not found logic is not working with the root uri. Only works when adding paths.

Can you provide a code snippet that illustrates what you're trying to achieve?

Yes. in my first post: #440 (comment)

[daviddev16]

Hi @AdriaanBoshoff, I tested your sample:

  THorse.All('*',
    procedure(Req: THorseRequest; Res: THorseResponse; Next: TProc)
    begin
      Res.Send('Custom Not Found');
    end);

  THorse.All('/test',
    procedure(Req: THorseRequest; Res: THorseResponse; Next: TProc)
    begin
      Res.Send('Test endpoint');
    end);

It actually works.

GET localhost:9000/ returns Status Code: 404 / Body: Custom Not Found
GET localhost:9000 returns Status Code: 404 / Body: Custom Not Found
GET localhost:9000/test returns Status Code: 200 / Body: Test endpoint
GET localhost:9000/test/ returns Status Code: 200 / Body: Test endpoint
GET localhost:9000/test/other returns Status Code: 404 / Body: Custom Not Found

[AdriaanBoshoff]

Hi @AdriaanBoshoff, I tested your sample:

THorse.All('*',
procedure(Req: THorseRequest; Res: THorseResponse; Next: TProc)
begin
Res.Send('Custom Not Found');
end);

THorse.All('/test',
procedure(Req: THorseRequest; Res: THorseResponse; Next: TProc)
begin
Res.Send('Test endpoint');
end);
It actually works.

GET localhost:9000/ returns Status Code: 404 / Body: Custom Not Found GET localhost:9000 returns Status Code: 404 / Body: Custom Not Found GET localhost:9000/test returns Status Code: 200 / Body: Test endpoint GET localhost:9000/test/ returns Status Code: 200 / Body: Test endpoint GET localhost:9000/test/other returns Status Code: 404 / Body: Custom Not Found

Would you mind sharing the project please? Maybe I'm doing osmething wrong

[daviddev16]

ISSUE440.zip

[daviddev16]

Any news about this one ? @AdriaanBoshoff