Potential fix for code scanning alert no. 1: Workflow does not contain permissions#3
Merged
Potential fix for code scanning alert no. 1: Workflow does not contain permissions#3
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Remy Duijsens <remyduijsens@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/HauntedMC/DataProvider/security/code-scanning/1
In general, the fix is to add an explicit
permissionsblock either at the workflow root (to apply to all jobs) or directly under thelintjob (to scope permissions per job). Since there is only one job shown and it only needs to read the repository code, we can setcontents: read. This both documents the intended privilege level and prevents theGITHUB_TOKENfrom having unnecessary write access if repository defaults are permissive.The best targeted fix without changing existing functionality is to add a job-level
permissionsblock underjobs.lintwithcontents: read.actions/checkout@v6works withcontents: read, and the Maven Checkstyle run does not require any GitHub write permissions. Concretely, in.github/workflows/ci-lint.yml, insert:immediately after the
runs-on: ubuntu-latestline (line 16 in the snippet). No imports or additional methods are required; this is purely a YAML workflow configuration change.Suggested fixes powered by Copilot Autofix. Review carefully before merging.