Dev 580 hdforce v1.1.3 test metrics and forcetime#10
Merged
laureng-hd merged 16 commits intoApr 23, 2025
Conversation
…tionary and universal metric naming convention.
…ttps://github.com/HawkinDynamics/hawkinPy into DEV-580-hdforce-v1.1.3-Test-Metrics-and-Forcetime
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the version to v1.1.3 and introduces several enhancements by adding new dependencies, improving metric naming consistency with an updated metric library, and enhancing time conversion and API endpoint customization via an orgName parameter.
- Updated project version and dependency management in pyproject.toml and documentation files.
- Added a new dtConverter helper and integrated its usage across GetTests functions.
- Enhanced GetMetrics and GetForceTime functionality, and added orgName support to AuthManager.
Reviewed Changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updated version to 1.1.3 and added pyarrow and pyjanitor deps |
| mkdocs.yml, LICENSE.txt, README.md | Updated version and minor content/documentation changes |
| hdforce/utils.py | Added dtConverter helper and improved Metrics.MetricDictionary |
| hdforce/GetTypes.py | Replaced API call with static dictionary for test types |
| hdforce/GetTests*.py (multiple files) | Standardized dtConverter usage and added last_sync_time column |
| hdforce/GetMetrics.py | Shifted to use Metrics.MetricDictionary and filter by test_type |
| hdforce/GetForceTime.py | Enhanced DataFrame construction for force time series data |
| hdforce/AuthManager.py | Added orgName parameter support for organization-specific endpoints |
| .github/workflows/push-test.yml | Minor workflow adjustments and typo fixes |
| docs/* | Updated documentation for new metric headers and version bump |
Files not reviewed (1)
- .vscode/settings.json: Language not supported
awales-hd
requested changes
Apr 21, 2025
Collaborator
awales-hd
left a comment
awales-hd
left a comment
There was a problem hiding this comment.
@laureng-hd generally lgtm, just a couple minor things
Co-authored-by: Andrew Wales <158098925+awales-hd@users.noreply.github.com>
…ttps://github.com/HawkinDynamics/hawkinPy into DEV-580-hdforce-v1.1.3-Test-Metrics-and-Forcetime
awales-hd
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
last_sync_timevalue toGetTestsfunctionsGetTestsmetric headers. Improved consistency of naming reflective of the metric libraryGetTeststo accept character strings in the format "YYYY-MM-DD" forfromandtoGetMetricsGetForceTimeto return all test typesorgNameparameter to AuthManager