Prevent soft-locking in RPGInterface demo (Fixes #267)#327
Closed
UncertainProd wants to merge 3 commits into
Closed
Prevent soft-locking in RPGInterface demo (Fixes #267)#327UncertainProd wants to merge 3 commits into
UncertainProd wants to merge 3 commits into
Conversation
Member
|
is this a bug with FlxUIPopup that we should fix, or normal behavior that the demo does not account for? |
Contributor
Author
|
Looking at FlxUIPopup, it looks like there's some code that forwards the CLICK_EVENT to the parent state only if one of the Edit: Searching around flixel-ui for the word "affirm" it looks like the above line is the only place where it's even mentioned so its probably a bug in flixel-ui. I made a PR for it here: HaxeFlixel/flixel-ui#259 |
Contributor
Author
|
Closing this in favor of HaxeFlixel/flixel-ui#259 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #267. For some reason,
FlxUIPopupdoes not propagateCLICK_EVENTcorrectly to the parent state.