Skip to content

Update win target to MSVC v145 and enable all possible Release optimizations#933

Open
Babouchot wants to merge 1 commit into
HaxeFoundation:masterfrom
Babouchot:master
Open

Update win target to MSVC v145 and enable all possible Release optimizations#933
Babouchot wants to merge 1 commit into
HaxeFoundation:masterfrom
Babouchot:master

Conversation

@Babouchot
Copy link
Copy Markdown
Contributor

This aims at enhancing the performance provided by hl.exe using latest compilers and release optimization.
see : https://devblogs.microsoft.com/cppblog/upgrading-c-projects-to-visual-studio-2026/#why-you-should-upgrade-your-c++-build-tools

@Babouchot
Copy link
Copy Markdown
Contributor Author

I mark this as draft as though it passes compilation checks on all platforms, the test suite still want to use vs2022 to compile hlc and thus fails because it is not installed by the image. So far I did not have time to troubleshoot where those VS versions are referenced to patch them. You may have an idea about that @yuxiaomao ?

@yuxiaomao
Copy link
Copy Markdown
Collaborator

@Babouchot
Copy link
Copy Markdown
Contributor Author

Thanks for the pointer @yuxiaomao 👍
So I pushed an update to Hl.hx in the haxe test suite and opened a pull request HaxeFoundation/haxe#12894
I suppose it now needs to be merged for the tests to have success here ?

@yuxiaomao
Copy link
Copy Markdown
Collaborator

In order, we need to

  • PR hashlink to add a template folder named vs2026 with corresponding template files (see vs2022 folder). ping me if you open that PR so I can merge.
  • Merge Haxe side PR
  • Then this PR will be run with the correct template

@Babouchot
Copy link
Copy Markdown
Contributor Author

I already added the vs2026 template folder in this very PR 🙂

@yuxiaomao
Copy link
Copy Markdown
Collaborator

Oh sorry I didn't check this PR content ^^'
Can you still split this PR, so one PR contains only the addition of vs2026 template ? So I'll be able to merge it + haxe side PR in order (I prefer not merging haxe before hashlink)

@Babouchot
Copy link
Copy Markdown
Contributor Author

I just added it here #934

@Babouchot Babouchot force-pushed the master branch 2 times, most recently from 6bac438 to 05faa5b Compare May 11, 2026 14:32
@Babouchot Babouchot marked this pull request as ready for review May 12, 2026 06:36
@yuxiaomao
Copy link
Copy Markdown
Collaborator

This PR is ready but I'll need to find some time to test the new build against Shiro's game before merge ^^'

@Babouchot
Copy link
Copy Markdown
Contributor Author

No problem I understand. I've been using this version as a custom build for some time now, @trethaller did also for a week or so. But I did not test all games, so there should definitely be some more testing to it.

@Babouchot
Copy link
Copy Markdown
Contributor Author

But for information about real world numbers: in the test I did on my machine, this could yield to a ~2ms gain on CPU time in CPU intensive situations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants