Skip to content

Fix 2 bugs with Language Standard Feature#1317

Merged
Simn merged 4 commits into
HaxeFoundation:masterfrom
FunkinCrew:bugfix/cxx-standard-fixes
Mar 13, 2026
Merged

Fix 2 bugs with Language Standard Feature#1317
Simn merged 4 commits into
HaxeFoundation:masterfrom
FunkinCrew:bugfix/cxx-standard-fixes

Conversation

@MAJigsaw77
Copy link
Copy Markdown
Contributor

  • Before it was implemented, we were able to set HXCPP_CPP17 inside a Build.xml but in the latest commit we cannot unless we define it inside the command, this behaviour is now fixed by moving the check inside createFileGroup, it allows the xml to be parsed first and then the set for the HXCPP_CPP17 would work just fine.
  • Setting the language standard on files element doesnt work as expected, if theres a section element inside the files element it, in that section the language standard that has been set my the parent will be forgotten, this behaviour is now fixed and allows sections to have the language standard work properly.

@tobil4sk
Copy link
Copy Markdown
Member

@Simn This addresses some regressions from #1301, so would be nice to get this looked at. Tests included!

@Simn
Copy link
Copy Markdown
Member

Simn commented Mar 13, 2026

Do we know what's going on with the hanging tests?

@tobil4sk
Copy link
Copy Markdown
Member

I haven't seen them reported anywhere yet, but I've just tested and they happen on master too so unrelated to this PR

@Simn
Copy link
Copy Markdown
Member

Simn commented Mar 13, 2026

That didn't happen on the latest master run so it must come from a Haxe update. Which isn't surprising considering the recent amount of Haxe updates!

@Simn Simn merged commit 4cc1828 into HaxeFoundation:master Mar 13, 2026
253 of 266 checks passed
@MAJigsaw77 MAJigsaw77 deleted the bugfix/cxx-standard-fixes branch March 13, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants