Skip to content

Feature/152 Add show and hide buttons for commentator box controls#160

Merged
BucketRaphi merged 42 commits into
masterfrom
feature/152-add-show-hide-buttons-for-comm-box
Jul 15, 2026
Merged

Feature/152 Add show and hide buttons for commentator box controls#160
BucketRaphi merged 42 commits into
masterfrom
feature/152-add-show-hide-buttons-for-comm-box

Conversation

@BucketRaphi

@BucketRaphi BucketRaphi commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Feature/Enhancement Pull Request

Feature

Adds #152 feature
Closes #152

Description

  • Adds buttons to show, hide, and temporarily show commentator box on score box overlay
  • Removes show interval input from dashboard sidebar, not needed

Affected Component(s)

  • Frontend (Angular Control Panel)
  • Overlays (new or enhanced)
  • Backend (ASP.NET Core)
  • Database/Migrations
  • Documentation

Feature Details

User-Facing Changes

The streamer now has finer control that allows them to show and hide the commentator box on the score box component

Technical Implementation

  • Added a new SignalR hub meant to only send events to all clients
  • Refactored display functionality in commentator box

Related

Testing

Test Scenarios

  1. Test if commentator box gets shown
  2. Test if commentator box gets hidden
  3. Test if commentator box gets shown for x amount of time

How to Test

  1. Open dashboard and overlay/score-box
  2. Click on button that triggers the event to show commentator box
  3. Check if commentator box gets shown on overlay
  4. Click on button that triggers the event to hide commentator box
  5. Check if commentator box gets hidden on overlay
  6. Set hide delay interval input to x amount of time
  7. Click on button that trigger the event to show commentator box temporarily
  8. Check if commentator box gets shown, and then disappears after x amount of time

Files Changed

New Files

  • Frontend/control-panel/src/app/services/signalr-events.ts
  • Frontend/control-panel/src/app/services/signalr-events.spec.ts
  • Backend/DSB.StreamBackend/Hubs/IEventClient.cs
  • Backend/DSB.StreamBackend/Hubs/EventHub.cs

Modified Files

  • Frontend/control-panel/src/app/overlay/commentator-box/commentator-box.ts
  • Frontend/control-panel/src/app/overlay/commentator-box/commentator-box.html
  • Frontend/control-panel/src/app/overlay/commentator-box/commentator-box.scss
  • Frontend/control-panel/src/app/overlay/score-box/score-box.ts
  • Frontend/control-panel/src/app/overlay/score-box/score-box.html
  • Frontend/control-panel/src/app/overlay/score-box/score-box.scss
  • Frontend/control-panel/src/app/layouts/sidebar/sidebar.ts
  • Frontend/control-panel/src/app/layouts/sidebar/sidebar.html
  • Frontend/control-panel/src/app/layouts/sidebar/sidebar.scss
  • Frontend/control-panel/src/app/services/signalr.spec.ts
  • Backend/DSB.StreamBackend/Program.cs

Backward Compatibility

  • Feature is fully backward compatible
  • Breaking changes: Major changes to commentator box and sidebar layout

Documentation

  • README updated
  • Inline code comments added
  • API documentation updated (if applicable)
  • Deployment notes added (if needed)

Checklist

  • Feature is complete and tested
  • Code follows repository conventions
  • Documentation is up to date
  • No breaking changes (or documented)
  • Tests pass
  • No new console errors or warnings

@BucketRaphi BucketRaphi self-assigned this Jul 2, 2026
@BucketRaphi BucketRaphi added UX/UI Changes to the User Interface or User Experience Frontend Anything related to the Frontend Backend Anything related to the Backend NoMerge Do not merge until specified criteria is reached Dashboard For issues related to the streaming Dashboard. High Priority For Issues and Pull Requests with high priority labels Jul 2, 2026
@BucketRaphi

Copy link
Copy Markdown
Collaborator Author

NoMerge because a database migrations needs to be made to remove an unused property, and because docs still need to be updated

Comment thread Backend/DSB.StreamBackend/Services/CommentatorBoxTimeDataService.cs Outdated
Comment thread Backend/DSB.StreamBackend/Services/SocialsService.cs Outdated
Comment thread Frontend/control-panel/src/app/layouts/sidebar/sidebar.html Outdated
Comment thread Frontend/control-panel/src/app/layouts/sidebar/sidebar.html Outdated
Comment thread Frontend/control-panel/src/app/layouts/sidebar/sidebar.html Outdated
Comment thread Frontend/control-panel/src/app/layouts/sidebar/sidebar.html Outdated
Comment thread Frontend/control-panel/src/app/overlays/commentator-box/commentator-box.ts Outdated
@Hazeolation Hazeolation added NoMerge Do not merge until specified criteria is reached and removed NoMerge Do not merge until specified criteria is reached labels Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Label "NoMerge" not applied. Merging enabled.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Label "NoMerge" on Pull Request. Merging blocked.

@Hazeolation

Copy link
Copy Markdown
Owner

Label refreshed for flow

@Hazeolation

Copy link
Copy Markdown
Owner

@BucketRaphi NoMerge condition met?

@BucketRaphi

Copy link
Copy Markdown
Collaborator Author

@BucketRaphi NoMerge condition met?

Still NoMerge imo because we need to sort out why DB migrations didn't create columns for the Socials and CommBox Time Data

@BucketRaphi BucketRaphi removed the NoMerge Do not merge until specified criteria is reached label Jul 15, 2026
@Hazeolation

Copy link
Copy Markdown
Owner

Merge Conflicts

@BucketRaphi
BucketRaphi merged commit 7184ddd into master Jul 15, 2026
14 checks passed
@BucketRaphi
BucketRaphi deleted the feature/152-add-show-hide-buttons-for-comm-box branch July 15, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backend Anything related to the Backend Dashboard For issues related to the streaming Dashboard. Frontend Anything related to the Frontend High Priority For Issues and Pull Requests with high priority UX/UI Changes to the User Interface or User Experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add buttons for showing / hiding commentator box

4 participants