Add V3 scan report field endpoint and wire up V3 field/value tables#1312
Open
Kehindecodes wants to merge 17 commits into
Open
Add V3 scan report field endpoint and wire up V3 field/value tables#1312Kehindecodes wants to merge 17 commits into
Kehindecodes wants to merge 17 commits into
Conversation
…portValue.Value t0 2048
Introduces ScanReportFieldIndexV3 with nested concepts and mapping recommendations, plus has_concepts/creation_type filters. Switches the field and value table pages to the V3 API and components, and adds an "Unmapped only" toggle to the concept data filter.
- Restore disabled={!canEdit} on AddConceptV3 in field columns (was hardcoded to false)
- Revert auth login URL back to NEXTAUTH_BACKEND_URL to match token refresh URL
- Add instanceId via useId() to all FormikSelect components to prevent SSR hydration mismatches - Remove unused getAllScanReportFieldsV3 from scanreports.ts
- Add showUnmappedFilter prop to ConceptDataFilter (defaults to false) - Pass showUnmappedFilter only on the values page, not the fields page - Remove unused Button, Link, ArrowLeft imports from values page
- Move api.* imports to top of third-party block to satisfy ruff I001 (alphabetical order) - Remove scan_report_table from ScanReportFieldV3 destructure (property doesn't exist on V3 type)
Member
|
Thanks @Kehindecodes this looks really good, it's a lot of files so will take a bit of time to review this side, as my head is not in the code right now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Migrates the scan report fields and values tables from the V2 API to a new V3 endpoint. The V3 endpoint returns fields with their concepts and mapping_recommendations embedded.
Key changes:
/api/v3/scanreports/<id>/tables/<table_pk>/fields/with filtering (has_concepts, creation_type, name), ordering, and paginationRelated Issues or other material
Related #1277
Screenshots, example outputs/behaviour etc.
Fields table with concepts mapped:
"Unmapped only" filter active:
✅ Added/updated tests?
-
TestScanReportFieldSerializerV3— verifiesScanReportFieldListSerializerV3includes nested concepts and recommendationsTestScanReportFieldListViewset— verifies the V3 endpoint returns fields with concepts, recommendations, and correctly filters by has_concepts=false