Skip to content

test: check if date_shift copies skipped rows#92

Closed
g-pechorin wants to merge 11 commits into
mainfrom
skiprows
Closed

test: check if date_shift copies skipped rows#92
g-pechorin wants to merge 11 commits into
mainfrom
skiprows

Conversation

@g-pechorin
Copy link
Copy Markdown

♻️ Refactor
🦋 Bug Fix
📝 Documentation
🛠️ Repo maintenance

PR Description

Tests to see if the shifting properly copies across "skipped rows"

Seems to show that #28 has already been fixed

Related Issues or other material

Related #
Closes #28

Screenshots, example outputs/behaviour etc.

✅ Added/updated tests?

  • This PR contains relevant tests / Or doesn't need to per the below explanation

[optional] What gif best describes this PR or how it makes you feel?

alt_text

dependabot Bot and others added 9 commits May 16, 2026 18:02
Bumps [pandas](https://github.com/pandas-dev/pandas) from 3.0.2 to 3.0.3.
- [Release notes](https://github.com/pandas-dev/pandas/releases)
- [Commits](pandas-dev/pandas@v3.0.2...v3.0.3)

---
updated-dependencies:
- dependency-name: pandas
  dependency-version: 3.0.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [types-openpyxl](https://github.com/python/typeshed) from 3.1.5.20260508 to 3.1.5.20260518.
- [Commits](https://github.com/python/typeshed/commits)

---
updated-dependencies:
- dependency-name: types-openpyxl
  dependency-version: 3.1.5.20260518
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ty](https://github.com/astral-sh/ty) from 0.0.37 to 0.0.39.
- [Release notes](https://github.com/astral-sh/ty/releases)
- [Changelog](https://github.com/astral-sh/ty/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ty@0.0.37...0.0.39)

---
updated-dependencies:
- dependency-name: ty
  dependency-version: 0.0.39
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.15.13 to 0.15.14.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@0.15.13...0.15.14)

---
updated-dependencies:
- dependency-name: ruff
  dependency-version: 0.15.14
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@g-pechorin g-pechorin requested a review from AndyRae as a code owner May 29, 2026 16:42
@g-pechorin g-pechorin changed the title Skiprows feat/shifting-shouldnt-skip-rows Jun 1, 2026
@g-pechorin g-pechorin changed the title feat/shifting-shouldnt-skip-rows test: check if date_shift copies skipped rows Jun 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Coverage

Coverage Report
FileStmtsMissBranchBrPartCoverMissing
nuh_helper/date_shift
   __init__.py17622761981%42–>51, 60, 80–87, 148–>146, 150–>144, 269–>283, 293–>308, 295, 404–405, 415, 423–>422, 427, 437, 444, 452–459, 488–>492, 495, 499, 505
   _excel.py942356870%27–>26, 34, 93, 124–137, 174, 207–>213, 220–231
   _parse.py30516285%31–40
nuh_helper/profile
   __init__.py958128011%33–40, 44–46, 52–69, 77–161
TOTAL4151311802965% 

Tests Skipped Failures Errors Time
69 0 💤 0 ❌ 0 🔥 8.861s ⏱️

@AndyRae
Copy link
Copy Markdown
Member

AndyRae commented Jun 2, 2026

So #28 - this is actually for shift_excel_dates whilst your function is testing shift_excel_dates_inplace - I'm not sure this is a problem we should put any priority on, as we almost entirely use shift_excel_dates_inplace

@g-pechorin g-pechorin closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Date shift: Fix skip rows not being transferred to the new sheet

2 participants