Fix access violations validating codes

Author: Grahame Grieve

library/ftx/fhir_valuesets.pas

@@ -829,6 +829,7 @@ function TValueSetChecker.check(path, system, version, code: String; abstractOk,
   ts : TStringList;
   vss : TFHIRValueSetW;
 begin
+  defLang := FLanguages.parse('en');
   FOpContext.addNote(FValueSet, 'Check "'+TTerminologyOperationContext.renderCoded(system, version, code)+'"');
   if (system = '') and not inferSystem then
   begin
@@ -2307,13 +2308,13 @@ function TValueSetChecker.checkConceptSet(path : String; cs: TCodeSystemProvider
                     listDisplays(displays, cs, loc);
                     if not (abstractOk or not cs.IsAbstract(FOpContext, loc)) then
                     begin
-                      OpContext.addNote(FValueSet, 'Filter '+ctxt.summary+': Code "'+code+'" found in '+ TTerminologyOperationContext.renderCoded(cs)+' but is abstract');
+                      OpContext.addNote(FValueSet, 'Filter '+fc.prop +' '+ CODES_TFhirFilterOperator[fc.Op]+ ' '+fc.value+': Code "'+code+'" found in '+ TTerminologyOperationContext.renderCoded(cs)+' but is abstract');
                       if (not FParams.membershipOnly) then
                         op.addIssue(isError, itBusinessRule, addToPath(path, 'code'), 'ABSTRACT_CODE_NOT_ALLOWED', FI18n.translate('ABSTRACT_CODE_NOT_ALLOWED', FParams.HTTPLanguages, [cs.systemUri, code]), oicCodeRule)
                     end
                     else if FValueSet.excludeInactives and cs.IsInactive(FOpContext, loc) then
                     begin
-                      OpContext.addNote(FValueSet, 'Filter '+ctxt.summary+': Code "'+code+'" found in '+ TTerminologyOperationContext.renderCoded(cs)+' but is inactive');
+                      OpContext.addNote(FValueSet, 'Filter '+fc.prop +' '+ CODES_TFhirFilterOperator[fc.Op]+ ' '+fc.value+': Code "'+code+'" found in '+ TTerminologyOperationContext.renderCoded(cs)+' but is inactive');
                       result := false;
                       if (not FParams.membershipOnly) then
                       begin
@@ -2323,7 +2324,7 @@ function TValueSetChecker.checkConceptSet(path : String; cs: TCodeSystemProvider
                     end
                     else
                     begin   
-                      OpContext.addNote(FValueSet, 'Filter '+ctxt.summary+': Code "'+code+'" found in '+ TTerminologyOperationContext.renderCoded(cs));
+                      OpContext.addNote(FValueSet, 'Filter '+fc.prop +' '+ CODES_TFhirFilterOperator[fc.Op]+ ' '+fc.value+': Code "'+code+'" found in '+ TTerminologyOperationContext.renderCoded(cs));
                       if vcc <> nil then
                         vcc.addCoding(cs.systemUri, cs.version, cs.code(FOpContext, loc), displays.preferredDisplay(FParams.workingLanguages));
                       result := true;
@@ -2332,7 +2333,7 @@ function TValueSetChecker.checkConceptSet(path : String; cs: TCodeSystemProvider
                   end;
                 end
                 else
-                  OpContext.addNote(FValueSet, 'Filter '+ctxt.summary+': Code "'+code+'" not found in '+ TTerminologyOperationContext.renderCoded(cs));
+                  OpContext.addNote(FValueSet, 'Filter '+fc.prop +' '+ CODES_TFhirFilterOperator[fc.Op]+ ' '+fc.value+': Code "'+code+'" not found in '+ TTerminologyOperationContext.renderCoded(cs));
               finally
                 loc.free;
               end;

release-notes.md

@@ -1,7 +1,7 @@
-## Change Notes for {ver}:
+## Change Notes for 3.7.13:
 
-* 
+* Fix access violations validating codes
 
 ## Conformance Notes:
 
-* 
+* tx.fhir.org passed 305 HL7 terminology service tests (mode 'tx.fhir.org', tests v1.7.7-SNAPSHOT, runner v6.5.14)

server/web_server.pas

@@ -1316,6 +1316,8 @@ procedure TFhirWebServer.logCrash(secure : boolean; id, clientIP: String; reques
         package.addStringUtf8(#13#10);
       end;
 
+
+      package.addStringUtf8(#13#10);
       package.addStringUtf8('-- Response --------------------------------------------------'#13#10);
       package.addStringUtf8(inttostr(resp.ResponseNo)+' '+resp.ResponseText);
       package.addStringUtf8(#13#10);