more Revise handling of inactive codes

Author: Grahame Grieve

exec/pack/Messages.properties

@@ -1472,6 +1472,7 @@ VALUESET_TXVER_BATCH_NOT_SUPPORTED = The terminology server {2} used for the Cod
 SD_ED_BIND_ALL_LOINC_CODES = This binding is to ALL LOINC codes, which includes part codes and answer list codes. The value set choice should be reviewed 
 SD_ED_BIND_ALLSCT_CODES = This binding is to ALL SNOMED CT codes, which includes qualifiers etc. The value set choice should be reviewed
 SD_ED_BIND_ALL_CPT_CODES = This binding is to ALL CPT codes, which includes modifiers and internal metadata codes. The value set choice should be reviewed
-INACTIVE_DISPLAY_FOUND_one =  ''{1}'' is no longer considered a correct display for code ''{2}'' (status = {4}). The correct display is ''{3}''.
-INACTIVE_DISPLAY_FOUND_other = ''{1}'' is no longer considered a correct display for code ''{2}'' (status = {4}). The correct display is one of {3}. 
-INACTIVE_CONCEPT_FOUND =  The concept ''{1}'' has a status of {0} and its use should be reviewed.
+INACTIVE_DISPLAY_FOUND_one =  ''{1}'' is no longer considered a correct display for code ''{2}'' (status = {4}). The correct display is ''{3}''
+INACTIVE_DISPLAY_FOUND_other = ''{1}'' is no longer considered a correct display for code ''{2}'' (status = {4}). The correct display is one of {3}
+INACTIVE_CONCEPT_FOUND =  The concept ''{1}'' has a status of {0} and its use should be reviewed
+CONCEPT_DEPRECATED_IN_VALUESET = The presence of the concept ''{1}'' in the system ''{0}'' in the value set {3} is marked with a status of {2} and its use should be reviewed

library/fhir3/fhir3_utilities.pas

@@ -5207,6 +5207,7 @@ function TFhirCodeSystemHelper.isDeprecated(concept: TFhirCodeSystemConcept): bo
 function TFhirCodeSystemHelper.codeStatus(concept: TFhirCodeSystemConcept): String;
 var
   p : TFhirCodeSystemConceptProperty;
+  s : String;
 begin
   result := '';
   for p in concept.property_List do

library/ftx/fhir_valuesets.pas

@@ -2157,7 +2157,7 @@ function TValueSetChecker.checkConceptSet(path : String; cs: TCodeSystemProvider
   prep : TCodeSystemProviderFilterPreparationContext;
   f : TCodeSystemProviderFilterContext;
   filters : Array of TCodeSystemProviderFilterContext;
-  msg, c : String;
+  msg, c, sstatus : String;
   cc : TFhirValueSetComposeIncludeConceptW;
   cfl : TFslList<TFhirValueSetComposeIncludeFilterW>;
 begin
@@ -2263,6 +2263,11 @@ function TValueSetChecker.checkConceptSet(path : String; cs: TCodeSystemProvider
           begin
             if vcc <> nil then
               vcc.addCoding(cs.systemUri, cs.version, cs.code(FOpContext, loc), displays.preferredDisplay(FParams.workingLanguages));
+            sstatus := cc.getExtensionString('http://hl7.org/fhir/StructureDefinition/structuredefinition-standards-status');
+            if StringArrayExistsSensitive(['withdrawn', 'deprecated'], sstatus) then
+              op.addIssue(isWarning, itBusinessRule, addToPath(path, 'code'), 'CONCEPT_DEPRECATED_IN_VALUESET', FI18n.translate('CONCEPT_DEPRECATED_IN_VALUESET', FParams.HTTPLanguages, [cs.systemUri, code, sstatus, vs.vurl]), oicCodeComment)
+            else if cc.hasExtension('http://hl7.org/fhir/StructureDefinition/valueset-deprecated') then
+              op.addIssue(isWarning, itBusinessRule, addToPath(path, 'code'), 'CONCEPT_DEPRECATED_IN_VALUESET', FI18n.translate('CONCEPT_DEPRECATED_IN_VALUESET', FParams.HTTPLanguages, [cs.systemUri, code, 'deprecated', vs.vurl]), oicCodeComment);
             result := true;
             exit;
           end;
@@ -3285,6 +3290,7 @@ function TFHIRValueSetExpander.includeCode(cs : TCodeSystemProvider; parent : TF
         if (vsExtList <> nil) then
           for ext in vsExtList do
             if StringArrayExists([EXT_VSSUPPLEMENT, 'http://hl7.org/fhir/StructureDefinition/valueset-deprecated',
+                                'http://hl7.org/fhir/StructureDefinition/structuredefinition-standards-status',
                                 'http://hl7.org/fhir/StructureDefinition/valueset-concept-definition', 'http://hl7.org/fhir/StructureDefinition/coding-sctdescid',
                                 'http://hl7.org/fhir/StructureDefinition/rendering-style', 'http://hl7.org/fhir/StructureDefinition/rendering-xhtml'], ext.url) then
               n.addExtensionV(ext.element.link);

release-notes.md

@@ -1,7 +1,8 @@
 ## Change Notes for 3.8.8:
 
 * Add support for testing snomed
+* Revise handling of inactive codes
 
 ## Conformance Notes:
 
-* tx.fhir.org passed 337 HL7 terminology service tests (mode 'tx.fhir.org', tests v1.7.7-SNAPSHOT, runner v6.6.0)
+* tx.fhir.org passed 344 HL7 terminology service tests (mode 'tx.fhir.org', tests v1.7.7-SNAPSHOT, runner v6.6.4)