1

Author: HeartLinked

src/iceberg/json_internal.h

@@ -77,9 +77,6 @@ ICEBERG_EXPORT Result<std::unique_ptr<SortOrder>> SortOrderFromJson(
 
 /// \brief Deserializes a JSON object into an unbound `SortOrder` object.
 ///
-/// This function parses the provided JSON and creates a `SortOrder` object without
-/// binding it to a schema. It does not validate the sort fields against any schema.
-///
 /// \param json The JSON object representing a `SortOrder`.
 /// \return An `expected` value containing either a `SortOrder` object or an error. If the
 /// JSON is malformed or missing expected fields, an error will be returned.
@@ -196,9 +193,6 @@ ICEBERG_EXPORT Result<std::unique_ptr<PartitionSpec>> PartitionSpecFromJson(
 
 /// \brief Deserializes a JSON object into an unbound `PartitionSpec` object.
 ///
-/// This function parses the provided JSON and creates a `PartitionSpec` object without
-/// binding it to a schema. It does not validate the partition fields against any schema.
-///
 /// \param json The JSON object representing a `PartitionSpec`.
 /// \return An `expected` value containing either a `PartitionSpec` object or an error. If
 /// the JSON is malformed or missing expected fields, an error will be returned.

src/iceberg/test/json_internal_test.cc

@@ -175,7 +175,7 @@ TEST(JsonInternalTest, PartitionSpec) {
   EXPECT_EQ(*spec, *parsed_spec_result.value());
 }
 
-TEST(JsonInternalTest, SortOrderFromJsonUnbound) {
+TEST(JsonInternalTest, SortOrderFromJson) {
   auto identity_transform = Transform::Identity();
   SortField st1(5, identity_transform, SortDirection::kAscending, NullOrder::kFirst);
   SortField st2(7, identity_transform, SortDirection::kDescending, NullOrder::kLast);
@@ -186,7 +186,7 @@ TEST(JsonInternalTest, SortOrderFromJsonUnbound) {
   EXPECT_EQ(*sort_order, *parsed);
 }
 
-TEST(JsonInternalTest, PartitionSpecFromJsonUnbound) {
+TEST(JsonInternalTest, PartitionSpecFromJson) {
   auto identity_transform = Transform::Identity();
   ICEBERG_UNWRAP_OR_FAIL(
       auto spec,