fix: Correct errors in update Properties implementation

Author: HeartLinked

src/iceberg/update/update_properties.cc

@@ -73,7 +73,18 @@ UpdateProperties& UpdateProperties::Remove(const std::string& key) {
 Result<PendingUpdate::ApplyResult> UpdateProperties::Apply() {
   ICEBERG_RETURN_UNEXPECTED(CheckErrors());
 
-  auto iter = updates_.find(TableProperties::kFormatVersion.key());
+  std::unordered_map<std::string, std::string> new_properties;
+  for (const auto& [key, value] : transaction_->current().properties.configs()) {
+    if (!removals_.contains(key)) {
+      new_properties[key] = value;
+    }
+  }
+
+  for (const auto& [key, value] : updates_) {
+    new_properties[key] = value;
+  }
+
+  auto iter = new_properties.find(TableProperties::kFormatVersion.key());
   if (iter != updates_.end()) {
     int parsed_version = 0;
     const auto& val = iter->second;
@@ -97,7 +108,7 @@ Result<PendingUpdate::ApplyResult> UpdateProperties::Apply() {
 
   if (auto schema = transaction_->current().Schema(); schema.has_value()) {
     ICEBERG_RETURN_UNEXPECTED(
-        MetricsConfig::VerifyReferencedColumns(updates_, *schema.value()));
+        MetricsConfig::VerifyReferencedColumns(new_properties, *schema.value()));
   }
 
   ApplyResult result;

src/iceberg/update/update_properties.h

@@ -43,12 +43,13 @@ class ICEBERG_EXPORT UpdateProperties : public PendingUpdate {
   ///
   /// The key can not be marked for previous removal and reserved property keys will be
   /// ignored.
+  /// \param key The property key to set
+  /// \param value The property value to set
+  /// \return Reference to this UpdateProperties for chaining
   UpdateProperties& Set(const std::string& key, const std::string& value);
 
   /// \brief Marks a property for removal.
   ///
-  /// The key can not be already marked for removal.
-  ///
   /// \param key The property key to remove
   /// \return Reference to this UpdateProperties for chaining
   UpdateProperties& Remove(const std::string& key);