add basic demo and test for POC

Author: HeartLinked

src/iceberg/catalog/rest/rest_catalog.cc

@@ -1,24 +1,7 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements.  See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership.  The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License.  You may obtain a copy of the License at
-//
-//   http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied.  See the License for the
-// specific language governing permissions and limitations
-// under the License.
+// In file: iceberg/catalog/rest/rest_catalog.cc
 
 #include "iceberg/catalog/rest/rest_catalog.h"
 
-#include <iostream>
-
 #include <cpr/cpr.h>
 
 namespace iceberg {
@@ -27,26 +10,12 @@ namespace rest {
 
 RestCatalog::RestCatalog(const std::string& base_url) : base_url_(std::move(base_url)) {}
 
-void RestCatalog::testCprIntegration() {
-  std::cout << "Testing CPR integration with base URL: " << base_url_ << std::endl;
-
+cpr::Response RestCatalog::testCprIntegration() {
   // Simple GET request demo
   cpr::Response r =
       cpr::Get(cpr::Url{"https://httpbin.org/get"}, cpr::Parameters{{"hello", "world"}});
 
-  std::cout << "Status code: " << r.status_code << std::endl;
-  std::cout << "Content-Type: " << r.header["content-type"] << std::endl;
-  std::cout << "Response text (first 200 chars): "
-            << r.text.substr(0, std::min<size_t>(200, r.text.size())) << "..."
-            << std::endl;
-
-  // Simulated REST catalog API request
-  std::string catalog_url = base_url_ + "/v1/namespaces";
-  std::cout << "\nSimulated catalog request to: " << catalog_url << std::endl;
-
-  // In real implementation, this would be:
-  // cpr::Response catalog_r = cpr::Get(cpr::Url{catalog_url},
-  //                                   cpr::Header{{"Content-Type", "application/json"}});
+  return r;
 }
 
 }  // namespace rest

src/iceberg/catalog/rest/rest_catalog.h

@@ -20,16 +20,18 @@
 
 #include <string>
 
+#include "cpr/response.h"
+
 namespace iceberg {
 namespace catalog {
 namespace rest {
 
 class RestCatalog {
  public:
-  RestCatalog(const std::string& base_url);
+  explicit RestCatalog(const std::string& base_url);
   ~RestCatalog() = default;
 
-  void testCprIntegration();
+  cpr::Response testCprIntegration();
 
  private:
   std::string base_url_;

test/CMakeLists.txt

@@ -125,3 +125,8 @@ if(ICEBERG_BUILD_BUNDLE)
                    parquet_schema_test.cc
                    parquet_test.cc)
 endif()
+
+if(ICEBERG_BUILD_REST_CATALOG)
+  add_iceberg_test(rest_catalog_test SOURCES rest_catalog_test.cc)
+  target_link_libraries(rest_catalog_test PRIVATE iceberg_rest_catalog_static)
+endif()

test/rest_catalog_test.cc

@@ -0,0 +1,42 @@
+// In your test file, e.g., rest_catalog_test.cc
+
+#include "iceberg/catalog/rest/rest_catalog.h"
+
+#include <gmock/gmock.h>
+#include <gtest/gtest.h>
+
+#include "cpr/error.h"
+#include "cpr/response.h"
+
+namespace iceberg {
+namespace catalog {
+namespace rest {
+
+class RestCatalogTest : public ::testing::Test {};
+
+TEST_F(RestCatalogTest, CanCreateRestCatalog) {
+  RestCatalog catalog("http://localhost:8181");
+  SUCCEED();
+}
+
+TEST_F(RestCatalogTest, MultipleCatalogInstances) {
+  RestCatalog catalog1("http://localhost:8181");
+  RestCatalog catalog2("http://localhost:8182");
+  SUCCEED();
+}
+
+TEST_F(RestCatalogTest, TestCprIntegration) {
+  RestCatalog catalog("http://localhost:8181");
+
+  cpr::Response response = catalog.testCprIntegration();
+
+  ASSERT_EQ(response.error.code, cpr::ErrorCode::OK)
+      << "CPR transport error: " << response.error.message;
+
+  EXPECT_EQ(response.status_code, 200);
+  EXPECT_THAT(response.text, ::testing::HasSubstr("\"hello\": \"world\""));
+}
+
+}  // namespace rest
+}  // namespace catalog
+}  // namespace iceberg