Skip to content

Commit 9752f91

Browse files
committed
modify meson
1 parent e25ff49 commit 9752f91

File tree

3 files changed

+9
-11
lines changed

3 files changed

+9
-11
lines changed

meson.build

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@ project(
3030
],
3131
)
3232

33+
cpp = meson.get_compiler('cpp')
34+
args = cpp.get_supported_arguments(['/bigobj'])
35+
add_project_arguments(args, language: 'cpp')
36+
3337
subdir('src')
3438

3539
install_data(

src/iceberg/test/meson.build

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -96,12 +96,6 @@ if get_option('rest').enabled()
9696
}
9797
endif
9898

99-
cpp = meson.get_compiler('cpp')
100-
cpp_bigobj_args = []
101-
if cpp.get_id() == 'msvc'
102-
cpp_bigobj_args += cpp.get_supported_arguments(['/bigobj'])
103-
endif
104-
10599
foreach test_name, values : iceberg_tests
106100
exc = executable(
107101
test_name,
@@ -110,7 +104,6 @@ foreach test_name, values : iceberg_tests
110104
'dependencies',
111105
[],
112106
),
113-
cpp_args: cpp_bigobj_args,
114107
)
115108
test(test_name, exc)
116109
endforeach

src/iceberg/test/rest_json_internal_test.cc

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -770,8 +770,8 @@ INSTANTIATE_TEST_SUITE_P(
770770
.test_name = "FullConfig",
771771
.expected_json_str =
772772
R"({"defaults":{"warehouse":"s3://bucket/warehouse"},"overrides":{"clients":"5"}})",
773-
.model = {.overrides = {{"clients", "5"}},
774-
.defaults = {{"warehouse", "s3://bucket/warehouse"}}}},
773+
.model = {.defaults = {{"warehouse", "s3://bucket/warehouse"}},
774+
.overrides = {{"clients", "5"}}}},
775775
// Only defaults
776776
CatalogConfigParam{
777777
.test_name = "OnlyDefaults",
@@ -792,8 +792,9 @@ INSTANTIATE_TEST_SUITE_P(
792792
.test_name = "WithEndpoints",
793793
.expected_json_str =
794794
R"({"defaults":{"warehouse":"s3://bucket/warehouse"},"overrides":{"clients":"5"},"endpoints":["GET /v1/config","POST /v1/tables"]})",
795-
.model = {.overrides = {{"clients", "5"}},
796-
.defaults = {{"warehouse", "s3://bucket/warehouse"}},
795+
.model = {.defaults = {{"warehouse", "s3://bucket/warehouse"}},
796+
.overrides = {{"clients", "5"}},
797+
797798
.endpoints = {"GET /v1/config", "POST /v1/tables"}}},
798799
// Only endpoints
799800
CatalogConfigParam{

0 commit comments

Comments
 (0)