Skip to content

Commit e0c8544

Browse files
committed
rc
1 parent 945796d commit e0c8544

1 file changed

Lines changed: 5 additions & 9 deletions

File tree

.github/workflows/rc.yml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,11 @@ jobs:
3535
archive:
3636
name: Archive
3737
runs-on: ubuntu-latest
38-
timeout-minutes: 10 # C++ submodules might take longer
38+
timeout-minutes: 5 # Can be reduced as we are not checking out submodules
3939
steps:
40-
- name: Checkout with submodules
40+
- name: Checkout
4141
uses: actions/checkout@v4
42-
with:
43-
submodules: 'recursive' # CRITICAL for C++ projects with dependencies
42+
# No longer need 'with: { submodules: 'recursive' }'
4443

4544
- name: Prepare for tag
4645
if: github.ref_type == 'tag'
@@ -56,8 +55,6 @@ jobs:
5655
- name: Prepare for branch
5756
if: github.ref_type == 'branch'
5857
run: |
59-
# Extract version from a file like VERSION.txt or CMakeLists.txt for branches
60-
# For simplicity, we'll hardcode a dev version here.
6158
version="0.1.0-dev"
6259
rc=100
6360
echo "VERSION=${version}" >> ${GITHUB_ENV}
@@ -70,13 +67,12 @@ jobs:
7067
id="apache-iceberg-cpp-${VERSION}-rc${RC}"
7168
tar_gz="${id}.tar.gz"
7269
echo "TAR_GZ=${tar_gz}" >> ${GITHUB_ENV}
73-
# Use tar instead of git archive to include submodules
74-
tar -czf "${tar_gz}" --transform "s,^./,${id}/," .
70+
# Reverted to the git archive command from the Go implementation
71+
git archive HEAD --prefix "${id}/" --output "${tar_gz}"
7572
sha512sum "${tar_gz}" > "${tar_gz}.sha512"
7673
7774
- name: Audit
7875
run: |
79-
# Make sure this script exists in your C++ repository
8076
dev/release/run_rat.sh "${TAR_GZ}"
8177
8278
- uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)