Skip to content

Commit 6fde5bd

Browse files
committed
refactor: use new min zfpkm peak height/distance
Signed-off-by: Josh Loecker <joshloecker@icloud.com>
1 parent 9bcda5f commit 6fde5bd

1 file changed

Lines changed: 6 additions & 8 deletions

File tree

main/como/rnaseq_gen.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -861,9 +861,8 @@ async def rnaseq_gen( # noqa: C901
861861
batch_ratio: float = 0.5,
862862
high_batch_ratio: float = 0.75,
863863
technique: FilteringTechnique | str = FilteringTechnique.ZFPKM,
864-
zfpkm_peak_height: float = 0.02,
865-
zfpkm_peak_distance: float = 1.0,
866-
zfpkm_bandwidth: float = 1.0,
864+
zfpkm_min_peak_height: float = 0.02,
865+
zfpkm_min_peak_distance: int = 1,
867866
cutoff: int | float | None = None,
868867
force_zfpkm_plot: bool = False,
869868
log_level: LogLevel = LogLevel.INFO,
@@ -892,9 +891,8 @@ async def rnaseq_gen( # noqa: C901
892891
:param high_batch_ratio: The percentage of batches that a gene must
893892
appear in for a gene to be marked "highly confident" in its expression
894893
:param technique: The filtering technique to use
895-
:param zfpkm_peak_height: The height of the zFPKM peak
896-
:param zfpkm_peak_distance: The distance of the zFPKM peak
897-
:param zfpkm_bandwidth: The bandwidth of the zFPKM
894+
:param zfpkm_min_peak_height: The height of the zFPKM peak
895+
:param zfpkm_min_peak_distance: The distance of the zFPKM peak
898896
:param cutoff: The cutoff value to use for the provided filtering technique
899897
:param force_zfpkm_plot: If too many samples exist, should plotting be done anyway?
900898
:param log_level: The level of logging to output
@@ -988,8 +986,8 @@ async def rnaseq_gen( # noqa: C901
988986
technique=technique,
989987
cut_off=cutoff,
990988
force_zfpkm_plot=force_zfpkm_plot,
991-
peak_parameters=PeakIdentificationParameters(height=zfpkm_peak_height, distance=zfpkm_peak_distance),
992-
bandwidth=zfpkm_bandwidth,
989+
zfpkm_min_peak_height=zfpkm_min_peak_height,
990+
zfpkm_min_peak_distance=zfpkm_min_peak_distance,
993991
output_boolean_activity_filepath=output_boolean_activity_filepath,
994992
output_zscore_normalization_filepath=output_zscore_normalization_filepath,
995993
output_zfpkm_plot_dirpath=output_zfpkm_plot_dirpath,

0 commit comments

Comments
 (0)