Skip to content

Commit 9bcda5f

Browse files
committed
refactor: do not drop na values, keep as much data for as long as possible
Signed-off-by: Josh Loecker <joshloecker@icloud.com>
1 parent 8076c76 commit 9bcda5f

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

main/como/rnaseq_gen.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -840,7 +840,8 @@ async def _process(
840840
expressed_count = len(boolean_matrix[boolean_matrix["expressed"] == 1])
841841
high_confidence_count = len(boolean_matrix[boolean_matrix["high"] == 1])
842842

843-
boolean_matrix.dropna(subset="entrez_gene_id", inplace=True)
843+
# TODO: 2025-OCT-31: commented out dropping entrez ids, should this be kept?
844+
# boolean_matrix.dropna(subset="entrez_gene_id", inplace=True)
844845
boolean_matrix.to_csv(output_boolean_activity_filepath, index=False)
845846
logger.info(f"{context_name} - Found {expressed_count} expressed genes, {high_confidence_count} of which are confidently expressed")
846847
logger.success(f"Wrote boolean matrix to {output_boolean_activity_filepath}")

0 commit comments

Comments
 (0)