This repository was archived by the owner on Feb 1, 2026. It is now read-only.
fix: handle silent I/O error in async serialization#1
Closed
erayack wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I/O errors occurring during async serialization in
Format::serialize_to_asynccould fail to propagate properly, potentially leading to silent failures when writing response bodies.Changes
From<std::io::Error>implementation to convert I/O errors intoGatewayError::InternalError, for proper error handling and HTTP 500 responsesserialize_to_asyncto explicitly convert write errors using.map_err(GatewayError::from)?, guaranteeing I/O failures are caught and reportedTesting
Added
test_serialize_to_async_propagates_write_errortest case that simulates a failing async writer and verifies the error is properly propagated asGatewayError::InternalError.