Task 001 solution: fix Placeholder RuntimeException#2
Open
HelloImKevo wants to merge 1 commit into
Open
Conversation
HelloImKevo
requested review from
arodriguez-tsys,
mgupta911,
ramitsuri and
sagrawal-im3
HelloImKevo
commented
Mar 26, 2020
Comment on lines
-92
to
-98
| LogHelper.writeWithTrace(Level.INFO, TAG, "Management area not implemented"); | ||
| break; | ||
|
|
||
| case TimeTracking: | ||
| LogHelper.writeWithTrace(Level.INFO, TAG, "Time Tracking area not implemented"); | ||
| break; | ||
|
|
Owner
Author
There was a problem hiding this comment.
I was considering leaving the log messages in place for the non-Placeholder buttons, what do you guys think?
Collaborator
There was a problem hiding this comment.
Why do you think they need to be removed? I think they can stay.
Owner
Author
There was a problem hiding this comment.
Hm... After further consideration, I concur! 👍
| import android.os.Bundle; | ||
|
|
||
| import com.imobile3.groovypayments.R; | ||
| import com.imobile3.groovypayments.logging.LogHelper; |
Owner
Author
There was a problem hiding this comment.
Maybe it would be better to retain the LogHelper import. Thoughts?
HelloImKevo
pushed a commit
that referenced
this pull request
Apr 8, 2020
* [Android] Initial UI implementation for Daily Reports * Added dimen value to the icon width and height * Code formate * revision changes
HelloImKevo
pushed a commit
that referenced
this pull request
Apr 8, 2020
* [Android] Initial UI implementation for Daily Reports * Added dimen value to the icon width and height * Code formate * revision changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is my proposed solution for BRD Task #1. I changed the switch case logic to remove the logging
statements and
RuntimeException(when a Placeholder button is clicked) and instead show a"Under Construction" dialog. How does it look?
Test Plan:
Additional Thoughts:
I removed some of the logs that are published to logcat, because they're basically "TODO" placeholder
verbiage. However, maybe these would be beneficial to keep around.
Also, since the
RuntimeExceptionhas been removed, it now just shows a Placeholder Alert Dialogwith text that isn't very helpful to the user. Maybe we should remove the buttons from the UI instead?
Related Issue(s):
https://jira.imobile3.com/browse/ABC-1234