Skip to content

Improved pc_autosave interval#3389

Open
MrKeiKun wants to merge 1 commit intoHerculesWS:masterfrom
MrKeiKun:fix-166-pc_autosave-interval
Open

Improved pc_autosave interval#3389
MrKeiKun wants to merge 1 commit intoHerculesWS:masterfrom
MrKeiKun:fix-166-pc_autosave-interval

Conversation

@MrKeiKun
Copy link
Copy Markdown
Contributor

@MrKeiKun MrKeiKun commented Sep 1, 2025

Pull Request Prelude

Changes Proposed

  1. Added set_interval function to timer interface:
  2. Improved pc_autosave logic:

Issues addressed: #166

Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
@MrKeiKun MrKeiKun force-pushed the fix-166-pc_autosave-interval branch from 33a31bf to dee8b95 Compare April 28, 2026 10:44
@skyleo
Copy link
Copy Markdown
Contributor

skyleo commented Apr 28, 2026

I don't really understand the point of this, can you try explaining the advantage?

Also doesn't this destroy the heap property that timers are in? (at least I think they are in a heap)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants