Part 1: Removal of various warnings supression and fixing their warnings, chagning class and delete C++ keywords in names, and changes related to compile common target as C++#3416

Open

hemagx wants to merge 35 commits into

hemagx commented Jun 30, 2026

Contributor

Pull Request Prelude

I have followed proper Hercules code styling.
I have read and understood the contribution guidelines before making this PR.
I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

The following warnings suppression has been removed and their warnings were fixed:

discarded-qualifiers
missing-field-initializers
incompatible-pointer-types-discards-qualifiers
deprecated-non-prototype
unused-but-set-variable
enum-enum-conversion
sign-compare

The following keywords has been changed in source:

class -> class_
delete -> delete_

ERS now has ownership over the name given to it, and similarly various functions that were taking char * and expecting constant strings were changed to take const char *

Issues addressed:

hemagx changed the base branch from stable to master

June 30, 2026 20:16

MishimaHaruna added 4 commits

July 1, 2026 04:51


          Fix some linter warnings about wrong indentation

340dc71

Warnings reported by clangd/clang-tidy

Signed-off-by: Haru <haru@dotalux.com>


          Fix some potential null-pointer errors reported by gcc-16

62fd1ea

Signed-off-by: Haru <haru@dotalux.com>


          Silence some null-pointer false positives reported by gcc-16

8d7a557

Signed-off-by: Haru <haru@dotalux.com>


          Fix broken of missing closing brackets in variable expressions

a5710a0

This never triggered due to an impossible condition, and it had the potential to overrun the buffer it was scanning

Signed-off-by: Haru <haru@dotalux.com>

MishimaHaruna force-pushed the compile_cpp branch from e38fa0a to 7d4d5d5 Compare

July 1, 2026 02:53

hemagx added 13 commits

July 1, 2026 20:40


          Remove -Wno-discarded-qualifiers and fix const qualifiers warnings

c54348b

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Remove warnings and warnings supressions that aren't available in C++

82876a1

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Fix sign comparison mismatch in common target

bb0b811

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Add signed version of WFIFO*, RFIFO*, RBUF*, WBUF* macros

43bd586

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Fixed @duel checking for an impossible return value -1 from duel->c…

83e8338

…reate, and changed duel->create to return unsigned integer as all functions expects an unsigned id

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Change owner in struct channel_data to be signed

8b2b499

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Corrected itemlist and cardlist in struct s_search_store_search…

f60be3a

… to be a signed int similar to how we store nameid

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Corrected zeny in struct chat_data to be a signed integer

b4a1a41

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Change item_count in clif interface unnamed structure cs to signe…

54e6144

…d int

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Change price of struct hCSData to signed int

2cc8578

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Change size of func anonymous structure of irc-bot interface to s…

226a791

…igned int

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Change job in struct questinfo to signed integer

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Change buildin_count in script interface to signed integer

eaee88a

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>

MishimaHaruna force-pushed the compile_cpp branch from 7d4d5d5 to 6f49cfa Compare

July 1, 2026 18:46

hemagx added 10 commits

July 3, 2026 01:58


          Fix sign comparison mismatch in map-server target

14b4d00

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Fix sign comparison mismatch in api-server target

68551f6

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Fix sign comparison mismatch in char-server target

d0b3386

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Fix sign comparison mismatch in plugins

fc69133

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Remove warning supression of sign compare

9e075e2

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Removal of no initialized fields warning supression

dae4c10

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Removal of -Wno-incompatible-pointer-types-discards-qualifiers and -W…

567dc4d

…no-deprecated-non-prototype

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Removal of no-unused-but-set-variable warning supression

b780905

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Removal of enum-enum-conversion warning supression

f55df08

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Change all identifiers named class to class_ for C++ compatability

49e233a

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>

hemagx added 7 commits

July 3, 2026 01:59


          Change ERS to always take ownership of the ERS name

adc6295

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Change all identifiers named delete to delete_ for C++ compatability

74d8c46

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Implement required code changes for common target to compile as C++

76bc179

* Add casts where necessary mostly for void * -> any other type
* Replaced use of min, max, swap macros with std variant
* Fixed where `const char` strings were passed/stored to non-const variables
* Updated VECTOR_RESIZE with C++ variant that relays on decltype to make type safe cast from memory manager


          Rename common target file sources from .c to .cpp

7fa829e

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Update HPM Hooks

536b99d

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Update the github workflow to work with the hybrid C/C++ build

43156b4

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Change all identifiers named new to new_ for C++ compatability

d601bce

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>

hemagx force-pushed the compile_cpp branch from cd29140 to d601bce Compare

July 2, 2026 22:59


          Fix wrong map-server path in the script-checker wrapper script and re…

4f1b8f4

…move old broken applescript counterpart

Signed-off-by: Haru <haru@dotalux.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet