Merge pull request #92 from svt-vverma/feature/datastore_unshare

Added support for datastore unshare

Author: sijeesh

CHANGELOG.md

@@ -26,6 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
     - endpoint support for /datastore/{datastoreId}/set_policy <POST>
     - endpoint support for /datastore/{datastoreId}/share <POST>
     - endpoint support for /datastore/{datastoreId}/standard_hosts <GET>
+    - endpoint support for /datastore/{datastoreId}/unshare <POST>
     - endpoint support for /external_stores <GET>
     - endpoint support for /external_stores <POST>
     - endpoint support for /external_stores/update_credentials <POST>

endpoints-support.md

@@ -29,6 +29,7 @@ Refer SimpliVity REST API doc for the resource endpoints documentation [HPE Simp
 |<sub>/datastores/{datastoreId}/set_policy</sub>                                             |POST    |
 |<sub>/datastores/{datastoreId}/share</sub>                                                  |POST    |
 |<sub>/datastores/{datastoreId}/standard_hosts</sub>                                         |GET     |
+|<sub>/datastores/{datastoreId}/unshare</sub>                                                |POST    |
 |     **External Stores**
 |<sub>/external_stores</sub>                                                                 |GET     |
 |<sub>/external_stores</sub>                                                                 |POST    |

examples/datastores.py

@@ -33,6 +33,9 @@
 ovc = OVC(config)
 datastores = ovc.datastores
 
+# variable declaration
+standard_host_name = "127.0.0.1"
+
 print("\n\nget_all with default params")
 all_datastores = datastores.get_all()
 for datastore in all_datastores:
@@ -110,6 +113,18 @@
 hosts = datastore_object.standard_hosts()
 print(f"{pp.pformat(hosts)} \n")
 
+# Share a datastore
+print("\n\nshare a datastore")
+datastore_obj = datastore_object.share(standard_host_name)
+print(f"{pp.pformat(datastore_obj)} \n")
+print(f"{pp.pformat(datastore_obj.data)} \n")
+
+# Stop sharing a datastore
+print("\n\nstop sharing a datastore")
+datastore_obj = datastore_object.unshare(standard_host_name)
+print(f"{pp.pformat(datastore_obj)} \n")
+print(f"{pp.pformat(datastore_obj.data)} \n")
+
 print("\n\ndatastore delete")
 all_datastores = datastores.get_all()
 count = len(all_datastores)

simplivity/resources/datastores.py

@@ -231,3 +231,21 @@ def share(self, host_name, timeout=-1):
         self.__refresh()
 
         return self
+
+    def unshare(self, host_name, timeout=-1):
+        """Stop sharing a datastore.
+
+        Args:
+          host_name: The name of the standard host that needs to stop sharing a datastore.
+          timeout: Time out for the request in seconds.
+
+        Returns:
+          object: Datastore object.
+        """
+
+        resource_uri = "{}/{}/unshare".format(URL, self.data["id"])
+        data = {"host_name": host_name}
+        self._client.do_post(resource_uri, data, timeout)
+        self.__refresh()
+
+        return self

tests/unit/resources/test_datastores.py

@@ -238,6 +238,24 @@ def test_share(self, mock_get, mock_post):
                                           {'host_name': "host1"},
                                           custom_headers=None)
 
+    @mock.patch.object(Connection, "post")
+    @mock.patch.object(Connection, "get")
+    def test_unshare(self, mock_get, mock_post):
+        resource_data = {'name': 'ds1', 'id': '12345', 'shares': [{'address': '127.0.0.1',
+                                                                   'host': 'host1',
+                                                                   'rw': True}]}
+        mock_post.return_value = None, [{'object_id': '12345'}]
+        mock_get.return_value = {'datastore': resource_data}
+
+        datastore_data = {'name': 'ds1', 'id': '12345'}
+        datastore = self.datastores.get_by_data(datastore_data)
+        datastore_obj = datastore.unshare("host1")
+        self.assertIsInstance(datastore_obj, datastores.Datastore)
+        self.assertEqual(datastore_obj.data, resource_data)
+        mock_post.assert_called_once_with('/datastores/12345/unshare',
+                                          {'host_name': "host1"},
+                                          custom_headers=None)
+
 
 if __name__ == '__main__':
     unittest.main()