Skip to content

Commit bda6b97

Browse files
mokevninclaude
andcommitted
refactor: drop dead query local assignments in resources
Five resource methods (image build/pull, plugin pull/upgrade, service update) assigned `query = encode_query_params(parsed)` but built the request query inline via `parsed.slice(*query_params)`, leaving the local unused. RuboCop flagged Lint/UselessAssignment, failing CI. Remove the dead assignments — no behavior change, the requests already send their query params. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 148e68f commit bda6b97

4 files changed

Lines changed: 8 additions & 13 deletions

File tree

Gemfile.lock

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,12 @@ GEM
5656
csv (3.3.5)
5757
drb (2.2.3)
5858
erubi (1.13.1)
59-
ffi (1.17.2-aarch64-linux-gnu)
60-
ffi (1.17.2-aarch64-linux-musl)
61-
ffi (1.17.2-arm64-darwin)
62-
ffi (1.17.2-x86_64-darwin)
63-
ffi (1.17.2-x86_64-linux-gnu)
64-
ffi (1.17.2-x86_64-linux-musl)
59+
ffi (1.17.4-aarch64-linux-gnu)
60+
ffi (1.17.4-aarch64-linux-musl)
61+
ffi (1.17.4-arm64-darwin)
62+
ffi (1.17.4-x86_64-darwin)
63+
ffi (1.17.4-x86_64-linux-gnu)
64+
ffi (1.17.4-x86_64-linux-musl)
6565
fiber-annotation (0.2.0)
6666
fiber-local (1.1.0)
6767
fiber-storage
@@ -79,7 +79,7 @@ GEM
7979
rb-inotify (~> 0.9, >= 0.9.10)
8080
logger (1.7.0)
8181
metrics (0.15.0)
82-
minitest (5.26.0)
82+
minitest (5.27.0)
8383
minitest-focus (1.4.0)
8484
minitest (>= 4, < 6)
8585
minitest-hooks (1.5.2)
@@ -181,7 +181,7 @@ GEM
181181
concurrent-ruby (~> 1.0)
182182
unicode-display_width (3.2.0)
183183
unicode-emoji (~> 4.1)
184-
unicode-emoji (4.1.0)
184+
unicode-emoji (4.2.0)
185185
uri (1.1.0)
186186
webmock (3.26.1)
187187
addressable (>= 2.8.0)

lib/docker_engine_ruby/resources/images.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,6 @@ def build(params)
147147
:version
148148
]
149149
parsed, options = DockerEngineRuby::ImageBuildParams.dump_request(params)
150-
query = DockerEngineRuby::Internal::Util.encode_query_params(parsed)
151150
@client.request(
152151
method: :post,
153152
path: "build",
@@ -457,7 +456,6 @@ def prune(params = {})
457456
def pull(params)
458457
query_params = [:changes, :from_image, :from_src, :message, :platform, :repo, :tag]
459458
parsed, options = DockerEngineRuby::ImagePullParams.dump_request(params)
460-
query = DockerEngineRuby::Internal::Util.encode_query_params(parsed)
461459
@client.request(
462460
method: :post,
463461
path: "images/create",

lib/docker_engine_ruby/resources/plugins.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,6 @@ def privileges(params)
182182
def pull(params)
183183
query_params = [:remote, :name]
184184
parsed, options = DockerEngineRuby::PluginPullParams.dump_request(params)
185-
query = DockerEngineRuby::Internal::Util.encode_query_params(parsed)
186185
@client.request(
187186
method: :post,
188187
path: "plugins/pull",
@@ -255,7 +254,6 @@ def set(name, params)
255254
def upgrade(name, params)
256255
query_params = [:remote]
257256
parsed, options = DockerEngineRuby::PluginUpgradeParams.dump_request(params)
258-
query = DockerEngineRuby::Internal::Util.encode_query_params(parsed)
259257
@client.request(
260258
method: :post,
261259
path: ["plugins/%1$s/upgrade", name],

lib/docker_engine_ruby/resources/services.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ def create(params)
5252
def update(id, params)
5353
query_params = [:version, :registry_auth_from, :rollback]
5454
parsed, options = DockerEngineRuby::ServiceUpdateParams.dump_request(params)
55-
query = DockerEngineRuby::Internal::Util.encode_query_params(parsed)
5655
@client.request(
5756
method: :post,
5857
path: ["services/%1$s/update", id],

0 commit comments

Comments
 (0)