|
1 | 1 | package main |
2 | 2 |
|
3 | 3 | import ( |
| 4 | + "bufio" |
4 | 5 | "context" |
5 | 6 | "encoding/json" |
| 7 | + "errors" |
| 8 | + "fmt" |
| 9 | + "io" |
6 | 10 | "os" |
7 | 11 |
|
8 | 12 | "github.com/jackc/pgx/v5" |
@@ -73,48 +77,164 @@ func enqueueBulkJobsFromFile(ctx context.Context, riverClient *river.Client[pgx. |
73 | 77 | } |
74 | 78 | defer file.Close() |
75 | 79 |
|
76 | | - var jobs []BulkJob |
77 | | - if err := json.NewDecoder(file).Decode(&jobs); err != nil { |
78 | | - return err |
79 | | - } |
| 80 | + decoder := json.NewDecoder(bufio.NewReader(file)) |
80 | 81 |
|
81 | | - tx, err := dbPool.Begin(ctx) |
| 82 | + // Peek first non-whitespace token |
| 83 | + tok, err := nextNonSpaceToken(decoder) |
82 | 84 | if err != nil { |
83 | | - return err |
| 85 | + return fmt.Errorf("cannot read file: %w", err) |
84 | 86 | } |
85 | | - defer tx.Rollback(ctx) |
86 | 87 |
|
87 | | - var jobsToInsert []river.InsertManyParams |
| 88 | + // NDJSON format (each line = JSON object) |
| 89 | + if tok != json.Delim('[') { |
| 90 | + return processNDJSON(ctx, decoder, riverClient, dbPool) |
| 91 | + } |
| 92 | + |
| 93 | + return processJSONArray(ctx, decoder, riverClient, dbPool) |
| 94 | +} |
| 95 | + |
| 96 | +// ------ JSON ARRAY VERSION ------ |
| 97 | +func processJSONArray(ctx context.Context, decoder *json.Decoder, riverClient *river.Client[pgx.Tx], dbPool *pgxpool.Pool) error { |
| 98 | + const batchSize = 500 |
| 99 | + |
| 100 | + batch := make([]river.InsertManyParams, 0, batchSize) |
| 101 | + total := 0 |
| 102 | + count := 0 |
| 103 | + |
| 104 | + for decoder.More() { |
| 105 | + var job BulkJob |
| 106 | + if err := decoder.Decode(&job); err != nil { |
| 107 | + return fmt.Errorf("decode error at item %d: %w", total, err) |
| 108 | + } |
| 109 | + |
| 110 | + params, err := toInsertParams(job) |
| 111 | + if err != nil { |
| 112 | + return err |
| 113 | + } |
88 | 114 |
|
89 | | - for i := range jobs { |
| 115 | + batch = append(batch, params) |
| 116 | + total++ |
| 117 | + count++ |
90 | 118 |
|
91 | | - var insertOpts *river.InsertOpts |
92 | | - if jobs[i].Metadata != nil { |
93 | | - metadataBytes, err := json.Marshal(jobs[i].Metadata) |
94 | | - if err != nil { |
| 119 | + if total%100 == 0 { |
| 120 | + log.Info().Msgf("Loaded %d jobs...", total) |
| 121 | + } |
| 122 | + |
| 123 | + if count == batchSize { |
| 124 | + if err := insertBatch(ctx, riverClient, dbPool, batch); err != nil { |
95 | 125 | return err |
96 | 126 | } |
97 | | - insertOpts = &river.InsertOpts{Metadata: metadataBytes} |
| 127 | + log.Info().Msgf("Inserted batch of %d jobs (total: %d)", batchSize, total) |
| 128 | + batch = batch[:0] |
| 129 | + count = 0 |
| 130 | + } |
| 131 | + } |
| 132 | + |
| 133 | + if len(batch) > 0 { |
| 134 | + if err := insertBatch(ctx, riverClient, dbPool, batch); err != nil { |
| 135 | + return err |
98 | 136 | } |
99 | | - jobsToInsert = append(jobsToInsert, river.InsertManyParams{ |
100 | | - Args: jobs[i].Args, |
101 | | - InsertOpts: insertOpts, |
102 | | - }) |
| 137 | + log.Info().Msgf("Inserted final batch of %d jobs (total: %d)", len(batch), total) |
103 | 138 | } |
104 | 139 |
|
105 | | - results, err := riverClient.InsertManyTx(ctx, tx, jobsToInsert) |
| 140 | + log.Info().Msgf("Bulk insert complete. Total jobs inserted: %d", total) |
| 141 | + return nil |
| 142 | +} |
| 143 | + |
| 144 | +// ------ NDJSON VERSION ------ |
| 145 | +func processNDJSON(ctx context.Context, decoder *json.Decoder, riverClient *river.Client[pgx.Tx], dbPool *pgxpool.Pool) error { |
| 146 | + const batchSize = 500 |
| 147 | + |
| 148 | + batch := make([]river.InsertManyParams, 0, batchSize) |
| 149 | + total := 0 |
| 150 | + count := 0 |
| 151 | + |
| 152 | + for { |
| 153 | + var job BulkJob |
| 154 | + if err := decoder.Decode(&job); err != nil { |
| 155 | + if errors.Is(err, io.EOF) { |
| 156 | + break |
| 157 | + } |
| 158 | + return err |
| 159 | + } |
| 160 | + |
| 161 | + params, err := toInsertParams(job) |
| 162 | + if err != nil { |
| 163 | + return err |
| 164 | + } |
| 165 | + |
| 166 | + batch = append(batch, params) |
| 167 | + total++ |
| 168 | + count++ |
| 169 | + |
| 170 | + if total%100 == 0 { |
| 171 | + log.Info().Msgf("Loaded %d jobs...", total) |
| 172 | + } |
| 173 | + |
| 174 | + if count == batchSize { |
| 175 | + if err := insertBatch(ctx, riverClient, dbPool, batch); err != nil { |
| 176 | + return err |
| 177 | + } |
| 178 | + log.Info().Msgf("Inserted batch of %d jobs (total: %d)", batchSize, total) |
| 179 | + batch = batch[:0] |
| 180 | + count = 0 |
| 181 | + } |
| 182 | + } |
| 183 | + |
| 184 | + if len(batch) > 0 { |
| 185 | + if err := insertBatch(ctx, riverClient, dbPool, batch); err != nil { |
| 186 | + return err |
| 187 | + } |
| 188 | + log.Info().Msgf("Inserted final batch of %d jobs (total: %d)", len(batch), total) |
| 189 | + } |
| 190 | + |
| 191 | + log.Info().Msgf("Bulk insert complete. Total jobs inserted: %d", total) |
| 192 | + return nil |
| 193 | +} |
| 194 | + |
| 195 | +// Helper: Read first non-space token |
| 196 | +func nextNonSpaceToken(dec *json.Decoder) (json.Token, error) { |
| 197 | + for { |
| 198 | + t, err := dec.Token() |
| 199 | + if err != nil { |
| 200 | + return nil, err |
| 201 | + } |
| 202 | + if _, ok := t.(json.Delim); ok || t != nil { |
| 203 | + return t, nil |
| 204 | + } |
| 205 | + } |
| 206 | +} |
| 207 | + |
| 208 | +func toInsertParams(job BulkJob) (river.InsertManyParams, error) { |
| 209 | + var insertOpts *river.InsertOpts |
| 210 | + if job.Metadata != nil { |
| 211 | + metaBytes, err := json.Marshal(job.Metadata) |
| 212 | + if err != nil { |
| 213 | + return river.InsertManyParams{}, err |
| 214 | + } |
| 215 | + insertOpts = &river.InsertOpts{Metadata: metaBytes} |
| 216 | + } |
| 217 | + return river.InsertManyParams{ |
| 218 | + Args: job.Args, |
| 219 | + InsertOpts: insertOpts, |
| 220 | + }, nil |
| 221 | +} |
| 222 | + |
| 223 | +func insertBatch(ctx context.Context, riverClient *river.Client[pgx.Tx], dbPool *pgxpool.Pool, batch []river.InsertManyParams) error { |
| 224 | + tx, err := dbPool.Begin(ctx) |
106 | 225 | if err != nil { |
107 | 226 | return err |
108 | 227 | } |
| 228 | + defer tx.Rollback(ctx) |
109 | 229 |
|
110 | | - if err := tx.Commit(ctx); err != nil { |
| 230 | + if _, err := riverClient.InsertManyTx(ctx, tx, batch); err != nil { |
111 | 231 | return err |
112 | 232 | } |
113 | 233 |
|
114 | | - log.Info().Msgf("Successfully enqueued %d jobs", len(results)) |
115 | | - return nil |
| 234 | + return tx.Commit(ctx) |
116 | 235 | } |
117 | 236 |
|
| 237 | + |
118 | 238 | func newRiverClient(driver *riverpgxv5.Driver) (*river.Client[pgx.Tx], error) { |
119 | 239 | return river.NewClient[pgx.Tx](driver, &river.Config{}) |
120 | 240 | } |
0 commit comments