[scramjet/core] add disableComputedWrap flag

Author: velzie

packages/scramjet/packages/core/rewriter/js/src/cfg.rs

@@ -40,6 +40,6 @@ pub struct Flags {
 	pub capture_errors: bool,
 	pub scramitize: bool,
 	pub do_sourcemaps: bool,
-	pub strict_rewrites: bool,
+	pub disable_computed_wrap: bool,
 	pub destructure_rewrites: bool,
 }

packages/scramjet/packages/core/rewriter/js/src/visitor.rs

@@ -70,6 +70,7 @@ where
 	}
 
 	fn handle_computed_member_expression(&mut self, it: &ComputedMemberExpression<'data>) {
+		if self.flags.disable_computed_wrap { return };
 		match &it.expression {
 			Expression::NullLiteral(_)
 			| Expression::BigIntLiteral(_)

packages/scramjet/packages/core/rewriter/native/src/main.rs

@@ -54,15 +54,15 @@ pub struct RewriterOptions {
 	sourcetag: String,
 	#[clap(long, default_value_t = false)]
 	is_module: bool,
-	
+
 	#[clap(long, default_value_t = false)]
 	capture_errors: bool,
 	#[clap(long, default_value_t = false)]
 	do_sourcemaps: bool,
 	#[clap(long, default_value_t = false)]
 	scramitize: bool,
 	#[clap(long, default_value_t = false)]
-	strict_rewrites: bool,
+	disable_computed_wrap: bool,
 	#[clap(long, default_value_t = false)]
 	destructure_rewrites: bool,
 }

packages/scramjet/packages/core/rewriter/native/src/rewriter.rs

@@ -92,7 +92,7 @@ impl NativeRewriter {
 					capture_errors: cfg.capture_errors,
 					do_sourcemaps: cfg.do_sourcemaps,
 					scramitize: cfg.scramitize,
-					strict_rewrites: cfg.strict_rewrites,
+					disable_computed_wrap: cfg.disable_computed_wrap,
 					destructure_rewrites: cfg.destructure_rewrites,
 				},
 				&rewriter

packages/scramjet/packages/core/rewriter/wasm/src/lib.rs

@@ -71,7 +71,7 @@ fn get_js_flags(obj: &Object, base: String, is_module: bool) -> Result<Flags> {
 		do_sourcemaps: get_bool(obj, "sourcemaps")?,
 		capture_errors: get_bool(obj, "captureErrors")?,
 		scramitize: get_bool(obj, "scramitize")?,
-		strict_rewrites: get_bool(obj, "strictRewrites")?,
+		disable_computed_wrap: get_bool(obj, "disableComputedWrap")?,
 		destructure_rewrites: get_bool(obj, "destructureRewrites")?,
 
 	})

packages/scramjet/packages/core/src/index.ts

@@ -33,7 +33,7 @@ export const defaultConfig: ScramjetConfig = {
 	},
 	flags: {
 		syncxhr: false,
-		strictRewrites: true,
+		disableComputedWrap: false,
 		rewriterLogs: false,
 		captureErrors: false,
 		cleanErrors: false,

packages/scramjet/packages/core/src/types.ts

@@ -19,7 +19,7 @@ export interface ScramjetVersionInfo {
  */
 export type ScramjetFlags = {
 	syncxhr: boolean;
-	strictRewrites: boolean;
+	disableComputedWrap: boolean;
 	rewriterLogs: boolean;
 	captureErrors: boolean;
 	cleanErrors: boolean;

packages/scramjet/packages/demo/src/components/FlagEditor.tsx

@@ -17,7 +17,7 @@ const flagStore = createStore<ScramjetFlags>(
 // Flag descriptions for better UX
 const flagDescriptions: Record<keyof ScramjetFlags, string> = {
 	syncxhr: "Enable synchronous XMLHttpRequest support",
-	strictRewrites: "enable extra security in js rewriter at a performance cost",
+	disableComputedWrap: "Skip deep js interception for better runtime speed",
 	cleanErrors: "prevent sites from noticing scramjet stack frames",
 	sourcemaps:
 		"prevent sites from noticing javascript transformations (at a performance cost)",