fix(ui): improve system info client RAM/OS/browser fallback#2766
Open
FixleCH wants to merge 1 commit intoHeyPuter:mainfrom
Open
fix(ui): improve system info client RAM/OS/browser fallback#2766FixleCH wants to merge 1 commit intoHeyPuter:mainfrom
FixleCH wants to merge 1 commit intoHeyPuter:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RAM: Unknownwhennavigator.deviceMemoryis missingOS: Linux UnknownwhenplatformVersionis not providedBrowser: Not-A.Brand, prefer meaningful UA hint ornavigator.userAgentfallbackChanges
getClientInfo():ram:navigator.deviceMemoryif availablewindow.performance.memory.jsHeapSizeLimitif available'Unknown'Not-A.Brandentry fromuaData.brandsnavigator.userAgentif result is generic/noisyOSasplatformonly whenplatformVersionis absentWhy
Avoid flaky client system info displayed in the widget for modern privacy-oriented browsers and old browser fallbacks.
Testing
navigator.deviceMemoryboth present and absentNotes