Fix Bug in HPMG bottomsolve_gpu (#1370)

Author: AlexanderSinn

src/mg_solver/HpMultiGrid.cpp

@@ -898,7 +898,7 @@ void bottomsolve_gpu (amrex::Real dx0, amrex::Real dy0, Array3<amrex::Real> cons
         int i = icell - j*lenx;
         j += lev_domain[0].smallEnd(1) + corner_offset;
         i += lev_domain[0].smallEnd(0) + corner_offset;
-        bool is_active = true;
+        bool is_active = j <= (lev_domain[0].bigEnd(1) - corner_offset);
 
         for (int ilev = 0; ilev < nlevs-1; ++ilev) {
             // set phi to zero

tests/checksum/benchmarks_json/laser_evolution.SI.2Rank.json

@@ -11,16 +11,16 @@
     "Psi": 0.0,
     "Sx": 0.0,
     "Sy": 0.0,
-    "aabs": 196.66890113956,
+    "aabs": 196.66110311143,
     "chi": 0.0,
     "jx": 0.0,
     "jx_beam": 0.0,
     "jy": 0.0,
     "jy_beam": 0.0,
     "jz_beam": 0.0,
     "laserChi": 0.0,
-    "laserEnvelope": 478.68654627351,
+    "laserEnvelope": 478.67956548082,
     "rhomjz": 0.0,
-    "|a^2|": 196.66890113946
+    "|a^2|": 196.66110311143
   }
 }

tests/checksum/benchmarks_json/transverse_benchmark.1Rank.json

@@ -1,25 +1,27 @@
 {
   "lev=0": {
-    "Bx": 109.05635145346,
-    "By": 14394.854178494,
-    "Bz": 55.916858300842,
-    "ExmBy": 29641.555791479,
-    "EypBx": 174.29898455178,
-    "Ez": 24147.017790522,
-    "Psi": 30545.70684051,
-    "Sx": 855702.74347016,
-    "Sy": 562321.82344904,
-    "chi": 1018054.6153949,
-    "jx": 26153.801526528,
+    "Bx": 109.05633036116,
+    "By": 14394.854151788,
+    "Bz": 55.916852053834,
+    "Ex": 24427.119878936,
+    "ExmBy": 29641.555774625,
+    "Ey": 264.30114167609,
+    "EypBx": 174.29892545973,
+    "Ez": 24147.017784648,
+    "Psi": 30545.706848031,
+    "Sx": 855703.07010712,
+    "Sy": 562321.63825953,
+    "chi": 1018054.6421633,
+    "jx": 26153.800120894,
     "jx_beam": 0.0,
-    "jy": 254.11189234126,
+    "jy": 254.11210918255,
     "jy_beam": 0.0,
     "jz_beam": 25198.504543228,
-    "rhomjz": 98737.09309244
+    "rhomjz": 98737.078769792
   },
   "beam": {
     "charge": 10465290.0,
-    "id": 54909091735281,
+    "id": 54761152624695,
     "mass": 10465290.0,
     "x": 2505383.794397,
     "y": 2505059.6140784,

tests/laser_STC.1Rank.sh

@@ -12,7 +12,6 @@ set -eu -o pipefail
 # Read input parameters
 HIPACE_EXECUTABLE=$1
 HIPACE_SOURCE_DIR=$2
-HIPACE_COMPUTE=$3
 
 HIPACE_EXAMPLE_DIR=${HIPACE_SOURCE_DIR}/examples/laser_STC
 HIPACE_TEST_DIR=${HIPACE_SOURCE_DIR}/tests

tests/laser_evolution.SI.2Rank.sh

@@ -26,11 +26,12 @@ FILE_NAME=`basename "$0"`
 TEST_NAME="${FILE_NAME%.*}"
 
 # Relative tolerance for checksum tests depends on the platform
-RTOL=1e-12 && [[ "$HIPACE_EXECUTABLE" == *"hipace"*".CUDA."* ]] && RTOL=1e-7
+RTOL=1e-12 && [[ "$HIPACE_EXECUTABLE" == *"hipace"*".CUDA."* ]] && RTOL=1e-8
 
 # Run the simulation with multigrid Poisson solver
 mpiexec -n 2 $HIPACE_EXECUTABLE $HIPACE_EXAMPLE_DIR/inputs_SI \
         lasers.solver_type = multigrid \
+        lasers.MG_tolerance_rel = 1e-7 \
         hipace.file_prefix = $TEST_NAME
 # Compare the result with theory
 $HIPACE_EXAMPLE_DIR/analysis_laser_vacuum.py --output-dir=$TEST_NAME