Add DST-2 DST-3 Poisson solver#1305
Merged
MaxThevenet merged 20 commits intoDec 18, 2025
Merged
Conversation
MaxThevenet
reviewed
Dec 1, 2025
Member
MaxThevenet
left a comment
There was a problem hiding this comment.
Thanks for this PR! Could you add a CI test with checksum?
MaxThevenet
reviewed
Dec 2, 2025
Member
MaxThevenet
left a comment
There was a problem hiding this comment.
Thanks! See minor comments below.
MaxThevenet
approved these changes
Dec 18, 2025
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a new FFT-based Poisson solver that uses DST type 2 for the forward transform and DST type 3 for the backward transform. Compared to the existing solver, which uses DST type 1, this internally uses an FFT of size n instead of n+1, giving different performance characteristics for different resolutions. Fast algorithms for the DST are implemented according to the book "Computational Frameworks for the Fast Fourier Transform" Algorithms 4.4.4 and 4.4.5.
Performance test:
Not only does the new Poisson solver nicely cover the 2^n resolution cases where the existing solver would have been slow, it is even a little bit faster at the respective optimal resolution.
New FFTDirichletQuick (DST-2 / DST-3)
FFTDirichletFast (DST-1)
Test of the MR boundary condition interpolation (new=FFTDirichletQuick, old=FFTDirichletFast):
constisconst)