Skip to content

Remove unused PhysConst#1317

Merged
MaxThevenet merged 1 commit into
Hi-PACE:developmentfrom
AlexanderSinn:Remove_unused_PhysConst
Dec 1, 2025
Merged

Remove unused PhysConst#1317
MaxThevenet merged 1 commit into
Hi-PACE:developmentfrom
AlexanderSinn:Remove_unused_PhysConst

Conversation

@AlexanderSinn
Copy link
Copy Markdown
Member

#1311 left some unused variables.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@lucafedeli88
Copy link
Copy Markdown
Contributor

Ah, curious that the compiler does not find the issue... When I tried implementing a new clang-tidy-based CI test, clang flagged these two variables as unused (see #1303) !

@AlexanderSinn
Copy link
Copy Markdown
Member Author

The compilers from the CI tests do catch it, except nvcc which I also use locally and didn't see it. However, they don't have warnings as errors enabled.

@MaxThevenet MaxThevenet merged commit 5476011 into Hi-PACE:development Dec 1, 2025
9 of 10 checks passed
@AlexanderSinn AlexanderSinn deleted the Remove_unused_PhysConst branch April 8, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants