Add verbose message to assert when using adaptive time step#1321
Merged
MaxThevenet merged 1 commit intoDec 2, 2025
Merged
Conversation
AlexanderSinn
approved these changes
Dec 2, 2025
Member
AlexanderSinn
left a comment
There was a problem hiding this comment.
Indeed, the laser solver assumes a constant dt between the three time steps that it uses. So it is not possible to use it with an adaptive (non-constant) time step.
MaxThevenet
approved these changes
Dec 2, 2025
Member
|
You're correct, thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happy to discard if this is incorrect, but it seems to me that the point of this assert is to avoid using the adaptive time step if laser pulses are present.
I tried doing that before and the code failed on the assert, but there was not any useful message.
If this is a general limitation, it's probably better to warn the user with a clear message.
constisconst)