Prevent plasma ionization past the atomic number#1343
Merged
MaxThevenet merged 4 commits intoJan 15, 2026
Merged
Conversation
9 tasks
Contributor
|
Thanks for the quick fix, @AlexanderSinn . I am testing your solution here: #1344 |
Contributor
|
After your fix the sanitizer does not find any other error. |
lucafedeli88
approved these changes
Jan 15, 2026
Contributor
lucafedeli88
left a comment
There was a problem hiding this comment.
Thanks for this quick fix, @AlexanderSinn
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lucafedeli88 found an out-of-bounds memory access in #1340 which could have caused ions to ionize to higher levels than they would have had electrons. In my quick test, the probability of ionizing too high ended up being zero, however this was not guaranteed. This changes the RNG results for ionization.
constisconst)