Skip to content

[DO NOT MERGE] Test PR 1343 Prevent plasma ionization past the atomic number #1344

Closed
lucafedeli88 wants to merge 8 commits into
Hi-PACE:developmentfrom
lucafedeli88:test_oom_fix
Closed

[DO NOT MERGE] Test PR 1343 Prevent plasma ionization past the atomic number #1344
lucafedeli88 wants to merge 8 commits into
Hi-PACE:developmentfrom
lucafedeli88:test_oom_fix

Conversation

@lucafedeli88
Copy link
Copy Markdown
Contributor

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn
Copy link
Copy Markdown
Member

The bug was fixed by #1343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants