Skip to content

Move plasma subcycle loop outside of kernel#1366

Closed
AlexanderSinn wants to merge 1 commit into
Hi-PACE:developmentfrom
AlexanderSinn:Move_plasma_subcycle_loop_outside_of_kernel
Closed

Move plasma subcycle loop outside of kernel#1366
AlexanderSinn wants to merge 1 commit into
Hi-PACE:developmentfrom
AlexanderSinn:Move_plasma_subcycle_loop_outside_of_kernel

Conversation

@AlexanderSinn
Copy link
Copy Markdown
Member

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant