Skip to content

Fix bug in grid ionization with multiple plasma species#1378

Merged
MaxThevenet merged 1 commit into
Hi-PACE:developmentfrom
AlexanderSinn:Fix_bug_in_grid_ionization_with_multiple_plasma_species
Apr 16, 2026
Merged

Fix bug in grid ionization with multiple plasma species#1378
MaxThevenet merged 1 commit into
Hi-PACE:developmentfrom
AlexanderSinn:Fix_bug_in_grid_ionization_with_multiple_plasma_species

Conversation

@AlexanderSinn
Copy link
Copy Markdown
Member

The electron contribution was applied to chi for each plasma species, however it should only be applied once.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn AlexanderSinn added the bug Something isn't working label Apr 16, 2026
Copy link
Copy Markdown
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@MaxThevenet MaxThevenet merged commit 7b30d39 into Hi-PACE:development Apr 16, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants