Skip to content

Switch to C++20#1380

Merged
MaxThevenet merged 4 commits into
Hi-PACE:developmentfrom
AlexanderSinn:Switch_to_C__20
Apr 22, 2026
Merged

Switch to C++20#1380
MaxThevenet merged 4 commits into
Hi-PACE:developmentfrom
AlexanderSinn:Switch_to_C__20

Conversation

@AlexanderSinn
Copy link
Copy Markdown
Member

@AlexanderSinn AlexanderSinn commented Apr 22, 2026

Now that AMReX-Codes/amrex#5265 was merged, hipace already uses C++20. This PR updates the CMake script, docs and CI accordingly. Additionally, one C++20 feature is used to make sure it actually works.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn AlexanderSinn added the build CMake, compilation, etc. label Apr 22, 2026
Comment thread src/utils/GPUUtil.H
Copy link
Copy Markdown
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@MaxThevenet MaxThevenet merged commit e9c19d7 into Hi-PACE:development Apr 22, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build CMake, compilation, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants