Don't use pragma omp simd in Deposition#1381
Merged
MaxThevenet merged 16 commits intoApr 22, 2026
Merged
Conversation
pragma omp simd in Deposition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like for MacOS, the beam deposition was vectorized with OMP. If particles deposit in the same cell, this would lead to incorrect results. Usually the compiler is not able to vectorize these functions, and we don't notice this.
Additionally, I fixed two cases where bool values were implicitly converted. This did not seem to affect results.
constisconst)