Render offline payment instruction tokens#1235
Merged
daveearley merged 2 commits intoJul 8, 2026
Merged
Conversation
Offline payment instructions can include order-specific references in organizer configuration, but public checkout resources were returning the stored template verbatim. That left buyers seeing unreplaced Liquid tokens and prevented organizers from matching bank transfers to orders. Render the instructions only when the public event settings resource has both event and order context, reusing the existing order-confirmation token builder so checkout and email references stay consistent. Purify the rendered HTML before returning it, and fall back to the stored instructions if rendering fails. Also prefer the order-loaded event payload on the payment page so the offline payment method receives the resource that contains order-aware settings.
realicon23
force-pushed
the
fix-offline-payment-instruction-tokens
branch
from
a21e3a7 to
185333e
Compare
Move Liquid rendering out of the public resources into OfflinePaymentInstructionsRenderService and EmailTokenContextBuilder so tokens render consistently on checkout, ticket lookup, and all order emails (custom template and default). Add a token dropdown to the offline payment instructions editor.
Contributor
|
Thank you for these changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{{ order.number }}Scope
This addresses the order-reference/template part of #1216. It intentionally does not redesign the wider offline-only checkout flow in the same PR.
Verification
/opt/homebrew/opt/php@8.4/bin/php backend/vendor/bin/phpunit backend/tests/Unit/Resources --no-coverage/opt/homebrew/opt/php@8.4/bin/php -lon touched PHP filesgit diff --check