Skip to content

Commit 355b70c

Browse files
committed
Prepping v0.2.0 for CRAN submission #45
1 parent 9af8e17 commit 355b70c

4 files changed

Lines changed: 28 additions & 26 deletions

File tree

RcppTskit/DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Type: Package
22
Package: RcppTskit
33
Title: R Access to the Tskit C API
4-
Version: 0.1.0.9000
4+
Version: 0.2.0
55
Date: 2026-01-27
66
Authors@R: c(
77
person("Gregor", "Gorjanc", , "gregor.gorjanc@gmail.com", role = c("aut", "cre", "cph"),

RcppTskit/NEWS.md

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@ All notable changes to RcppTskit are documented in this file.
44
The file format is based on [Keep a Changelog](https://keepachangelog.com),
55
and releases adhere to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7-
## [0.2.0] - 2026-MM-DD
8-
9-
This will be 0.2.0 release.
7+
## [0.2.0] - 2026-02-09
108

119
### Added (new features)
1210

@@ -18,20 +16,24 @@ This will be 0.2.0 release.
1816
- Added TableCollection and reticulate Python round-trip helpers:
1917
`TableCollection$r_to_py()` and `tc_py_to_r()`.
2018

21-
- Changed the R API to follow Python-style flags for loading:
19+
- Changed the R API to follow tskit Python API for loading:
2220
`ts_load()`, `tc_load()`, `TreeSequence$new()`, and `TableCollection$new()`
2321
now use `skip_tables` and `skip_reference_sequence` logical arguments instead
2422
of an integer `options` bitmask.
2523

2624
- Removed user-facing `options` from `TreeSequence$dump()`,
2725
`TreeSequence$dump_tables()`, `TableCollection$dump()`, and
28-
`TableCollection$tree_sequence()` in line with the Python API.
29-
These methods now call the C++ layer with
30-
fixed options matching the Python API.
26+
`TableCollection$tree_sequence()` to match R API with the tskit Python API,
27+
while C++ API has the bitwise `options` like the tskit C API.
28+
29+
- The bitwise options passed to C++ are now validated.
30+
31+
### Changed
3132

32-
- The bitwise options passed to the C++ functions are now rigorously validated.
33+
- We now specify C++20 standard to go around the CRAN Windows issue,
34+
see #63 for further details.
3335

34-
- Renamed unexported functions in this way `RcppTskit:::ts_load_ptr()` to
36+
- Renamed unexported functions from `RcppTskit:::ts_load_ptr()` to
3537
`RcppTskit:::ts_ptr_load()`.
3638

3739
## [0.1.0] - 2026-01-26

RcppTskit/cran-comments.md

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,31 +2,31 @@
22

33
0 errors | 0 warnings | 1 note
44

5-
* This is a new release.
5+
* This is a new release (v0.2.0).
66

7-
* I have tested on my local MacOS laptop using:
7+
* It passes checks on my local MacOS laptop using:
88
`devtools::check()` and
9-
`devtools::check(remote = TRUE, manual = TRUE)`. Both pass.
9+
`devtools::check(remote = TRUE, manual = TRUE)`.
1010

11-
* I have also used R CMD check GitHub action on MacOS, Windows, and
12-
Ubunutu (oldrelease, release, and devel); and all pass as you can
13-
see at https://github.com/HighlanderLab/RcppTskit/actions/runs/21542139159.
11+
* It passes checks on GitHub actions on MacOS, Windows, and Linux:
12+
https://github.com/HighlanderLab/RcppTskit/actions/workflows/R-CMD-check.yaml.
1413

15-
* I have also used R universe build systems and get pass on all 13 combinations
16-
as you can see at https://highlanderlab.r-universe.dev/RcppTskit
14+
* It passes checks on R universe on all 13 combinations:
15+
https://highlanderlab.r-universe.dev/RcppTskit#checktable.
1716

18-
* `urlchecker::url_check()` also passes.
17+
* It passes on CRAN win-builder too.
1918

20-
* On https://win-builder.r-project.org/UmBp28nqBAkU/00check.log
21-
I get this warning:
19+
* On my previous CRAN submission (v0.1.0), I got this warning:
2220

2321
```
2422
* checking whether package 'RcppTskit' can be installed ... WARNING
2523
Found the following significant warnings:
2624
../inst/include/tskit/tskit/core.h:171:21: warning: C++ designated initializers only available with '-std=c++20' or '-std=gnu++20' [-Wc++20-extensions]
2725
```
2826

29-
Discussion with upstream devs of tskit indicates that this is due
30-
to how the build tools have been built for this platform since
31-
we could not replicate the warning on any of our platforms even when
32-
tweaking the flags - see https://github.com/tskit-dev/tskit/issues/3375.
27+
I have now addressed it by setting CXX_STD = CXX20 in Makevars.in.
28+
Note that discussion with upstream devs of tskit indicates that this warning
29+
seems to arise from how the build tools have been built for CRAN windows,
30+
since we could not replicate the warning on any of platforms even when
31+
tweaking the flags, including Windows. See the above checks and
32+
https://github.com/tskit-dev/tskit/issues/3375.

RcppTskit/notes_pkg_dev.Rmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ PATCH version when you make backward compatible bug fixes
128128
- Describe 1 ...
129129
- Describe 2 ...
130130
131-
### Changed (for )changes in existing functionality)
131+
### Changed (for changes in existing functionality)
132132
### Deprecated (soon-to-be removed features)
133133
### Removed (now removed features)
134134
### Fixed (bug fixes)

0 commit comments

Comments
 (0)