|
2 | 2 |
|
3 | 3 | 0 errors | 0 warnings | 1 note |
4 | 4 |
|
5 | | -* This is a new release. |
| 5 | +* This is a new release (v0.2.0). |
6 | 6 |
|
7 | | -* I have tested on my local MacOS laptop using: |
| 7 | +* It passes checks on my local MacOS laptop using: |
8 | 8 | `devtools::check()` and |
9 | | - `devtools::check(remote = TRUE, manual = TRUE)`. Both pass. |
| 9 | + `devtools::check(remote = TRUE, manual = TRUE)`. |
10 | 10 |
|
11 | | -* I have also used R CMD check GitHub action on MacOS, Windows, and |
12 | | - Ubunutu (oldrelease, release, and devel); and all pass as you can |
13 | | - see at https://github.com/HighlanderLab/RcppTskit/actions/runs/21542139159. |
| 11 | +* It passes checks on GitHub actions on MacOS, Windows, and Linux: |
| 12 | + https://github.com/HighlanderLab/RcppTskit/actions/workflows/R-CMD-check.yaml. |
14 | 13 |
|
15 | | -* I have also used R universe build systems and get pass on all 13 combinations |
16 | | - as you can see at https://highlanderlab.r-universe.dev/RcppTskit. |
| 14 | +* It passes checks on R universe on all 13 combinations: |
| 15 | + https://highlanderlab.r-universe.dev/RcppTskit#checktable. |
17 | 16 |
|
18 | | -* `urlchecker::url_check()` also passes. |
| 17 | +* It passes on CRAN win-builder too. |
19 | 18 |
|
20 | | -* On https://win-builder.r-project.org/UmBp28nqBAkU/00check.log |
21 | | - I get this warning: |
| 19 | +* On my previous CRAN submission (v0.1.0), I got this warning: |
22 | 20 |
|
23 | 21 | ``` |
24 | 22 | * checking whether package 'RcppTskit' can be installed ... WARNING |
25 | 23 | Found the following significant warnings: |
26 | 24 | ../inst/include/tskit/tskit/core.h:171:21: warning: C++ designated initializers only available with '-std=c++20' or '-std=gnu++20' [-Wc++20-extensions] |
27 | 25 | ``` |
28 | 26 |
|
29 | | - Discussion with upstream devs of tskit indicates that this is due |
30 | | - to how the build tools have been built for this platform since |
31 | | - we could not replicate the warning on any of our platforms even when |
32 | | - tweaking the flags - see https://github.com/tskit-dev/tskit/issues/3375. |
| 27 | + I have now addressed it by setting CXX_STD = CXX20 in Makevars.in. |
| 28 | + Note that discussion with upstream devs of tskit indicates that this warning |
| 29 | + seems to arise from how the build tools have been built for CRAN windows, |
| 30 | + since we could not replicate the warning on any of platforms even when |
| 31 | + tweaking the flags, including Windows. See the above checks and |
| 32 | + https://github.com/tskit-dev/tskit/issues/3375. |
0 commit comments