Using DNDEBUG to remove asserts #5

Author: gregorgorjanc

README.md

@@ -83,7 +83,7 @@ git clone https://github.com/HighlanderLab/tskitr.git
 
 If you plan to update `tskit`, follow instructions in `extern/README.md`.
 
-Then open `tskitr` package directory in your favourite R IDE (Positron, RStudio, text-editor-of-your-choice, etc.), implement your changes and run:
+Then open `tskitr` package directory in your favourite R IDE (Positron, RStudio, text-editor-of-your-choice, etc.), implement your changes and run (in R):
 
 ```
 # Note that the tskitr package is in the tskitr sub-directory

tskitr/src/Makevars.in

@@ -30,11 +30,7 @@ OBJECTS = $(TSKIT_OBJECTS) $(TSKITR_OBJECTS)
 PKG_CPPFLAGS = -I../inst/include -I../inst/include/tskit -I../inst/include/tskit/tskit
 
 # Compiler flags
-# TODO: Remove asserts as per Writting R extensions manual #5
-#       https://github.com/HighlanderLab/tskitr/issues/5
-#       Note clang++ uses -DNDEBUG by default (see below output from devtools::install()) #5
-# clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I../inst/include -I../inst/include/tskit -I../inst/include/tskit/tskit -I/opt/homebrew/opt/gettext/include -I'/Users/ggorjanc/Library/R/arm64/4.5/library/Rcpp/include' -I/opt/R/arm64/include    -fPIC  -falign-functions=64 -Wall -g -O2   -c tskitr.cpp -o tskitr.o
-# PKG_CFLAGS = -DNDEBUG
+PKG_CFLAGS = -DNDEBUG # to remove calls to assert()
 # TODO: Should we port any flags from extern/tskit/c/meson.build to R build system? #6
 #       https://github.com/HighlanderLab/tskitr/issues/6
 #       See default flags used by clang  (see below output from devtools::install())