Skip to content

Commit e36f9db

Browse files
committed
Work towards Makevars.win #23
1 parent f8b404e commit e36f9db

3 files changed

Lines changed: 5 additions & 8 deletions

File tree

RcppTskit/configure.win

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,2 @@
11
#!/bin/sh
2-
"${R_HOME}/bin/Rscript" tools/configure.R
3-
# TODO: Use "${R_HOME}/bin${R_ARCH_BIN}/Rscript" in configure.win on Windows #18
4-
# https://cran.r-project.org/doc/manuals/r-devel/R-exts.html#Configure-and-cleanup
5-
# https://github.com/HighlanderLab/RcppTskit/issues/18
2+
"${R_HOME}/bin${R_ARCH_BIN}/Rscript" tools/configure.R

RcppTskit/src/Makevars.in

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,3 @@ tskit/%.o: tskit/%.c
5050

5151
# Linking
5252
PKG_LIBS = @RCPPTSKIT_LIB@
53-
54-
# TODO: Create Makevars.win #23
55-
# https://github.com/HighlanderLab/RcppTskit/issues/23

RcppTskit/tools/configure.R

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ renderMakevars <- function(template, output) {
3838
}
3939

4040
# renderMakevars(template = "this_should_fail", output = "before_getting_to_output")
41+
4142
if (.Platform$OS.type == "unix") {
4243
# readLines(con = "src/Makevars.in")
4344
success <- renderMakevars(
@@ -47,7 +48,9 @@ if (.Platform$OS.type == "unix") {
4748
} else {
4849
# readLines(con = "src/Makevars.win.in")
4950
success <- renderMakevars(
50-
template = "src/Makevars.win.in",
51+
# Currently, both Unix and Windows use the same template
52+
# template = "src/Makevars.win.in",
53+
template = "src/Makevars.in",
5154
output = "src/Makevars.win"
5255
)
5356
}

0 commit comments

Comments
 (0)