feat(release): build static Linux x64 binaries with musl#3274
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Thanks @wavezhang for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
Switch Linux x64 release builds from dynamic glibc (x86_64-unknown-linux-gnu) to static musl (x86_64-unknown-linux-musl) in GitHub Actions release workflow. - Change matrix target for codewhale and codewhale-tui linux-x64 to musl - Add dedicated musl build step: install musl-tools, add musl target - Skip libdbus-1-dev install for musl targets (keyring gated at compile time) - Skip generic Build step for musl (handled by dedicated step) - Parity with CNB pipeline (.cnb.yml) which already uses musl (PR Hmbown#2903) Static binaries have no glibc/libdbus runtime dependency and run on any Linux distribution without additional packages.
7572bd1 to
814a922
Compare
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
thank you for this!! |
Summary
Switch Linux x64 release builds from dynamic glibc (
x86_64-unknown-linux-gnu) to static musl (x86_64-unknown-linux-musl) in the GitHub Actions release workflow.This is the GitHub Actions counterpart to PR #2903 which added musl static builds to the CNB pipeline (
.cnb.yml).Changes
x86_64-unknown-linux-gnux86_64-unknown-linux-muslx86_64-unknown-linux-gnux86_64-unknown-linux-muslcargo buildDetails
targetforcodewhale-linux-x64andcodewhale-tui-linux-x64fromgnutomuslmusl-tools, addsx86_64-unknown-linux-musltarget, then buildskeyringfeature is already gated behindtarget != muslincrates/secrets(from PR feat: build static linux x64 binaries with musl #2903), so nolibdbus-1-devneededWhy
Static musl binaries have no glibc/libdbus runtime dependency and run on any Linux distribution without additional packages — matching what the CNB pipeline already produces.
Testing
This change mirrors the CNB pipeline approach (PR #2903, merged). The GitHub Actions workflow will be validated on the next release dispatch.