i18n: add Korean (ko) locale support#4347
Closed
moduvoice wants to merge 1 commit into
Closed
Conversation
Adds full Korean translation (752/752 keys) and registers Locale::Ko throughout the codebase, mirroring the existing vi/ja/zh-Hans/es-419/ pt-BR pattern: - crates/tui/locales/ko.json: new 752-key Korean translation - crates/tui/src/localization.rs: Locale::Ko enum variant, code/display name, ALL_LOCALES lists, locale-specific string match arms, and locale-code parsing - crates/tui/src/tui/setup/mod.rs: (Locale::Ko, ...) match arms for setup-flow strings - crates/tui/src/commands/groups/config/config.rs: Locale::Ko display in `/config` output - crates/tui/src/commands/groups/debug/change.rs: Locale::Ko display name in language switcher - crates/tui/src/tui/onboarding/language.rs: Korean added as option 9 in the onboarding language picker - All 6 pre-existing locale JSON files: fixed onboarding OnboardLanguageFooter hint from "Press 1-8" to "Press 1-9" to account for the new 9th language option
|
Thanks @moduvoice for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
Hmbown
pushed a commit
that referenced
this pull request
Jul 12, 2026
Adds full Korean translation (752/752 keys) and registers Locale::Ko throughout the codebase, mirroring the existing vi/ja/zh-Hans/es-419/ pt-BR pattern: - crates/tui/locales/ko.json: new 752-key Korean translation - crates/tui/src/localization.rs: Locale::Ko enum variant, code/display name, ALL_LOCALES lists, locale-specific string match arms, and locale-code parsing - crates/tui/src/tui/setup/mod.rs: (Locale::Ko, ...) match arms for setup-flow strings - crates/tui/src/commands/groups/config/config.rs: Locale::Ko display in `/config` output - crates/tui/src/commands/groups/debug/change.rs: Locale::Ko display name in language switcher - crates/tui/src/tui/onboarding/language.rs: Korean added as option 9 in the onboarding language picker - All 6 pre-existing locale JSON files: fixed onboarding OnboardLanguageFooter hint from "Press 1-8" to "Press 1-9" to account for the new 9th language option Harvested from PR #4347 by @moduvoice
Hmbown
added a commit
that referenced
this pull request
Jul 12, 2026
Summarize the underwater interaction system, treatment/motion independence, compact-room fixes, footer notice ownership, ASCII tier, and localization parity work in the 0.8.68 changelog section, and credit the harvested community work: Korean locale (PR #4347 @moduvoice), Anthropic schema sanitization (PR #4346 @qinlinwang), Anthropic cache-write pricing (PR #4348 @knqiufan), NetBSD bindgen (PR #4349 @ci4ic4), and the #4208 copy-pollution report (@eugenicum).
|
Thanks @moduvoice — your contribution landed in
Closing this PR now that the code is on If you want to land more work and would prefer your future PRs merge cleanly without a harvest step, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This adds Korean (
ko) translation support — to help Korean-speaking users use thisopen-source project more comfortably in their own language.
한국 사람들의 오픈소스 이용에 도움이 되게 하기 위해서 한글화 작업을 하였습니다.
Changes
crates/tui/locales/ko.jsonwith all 752 leaf keys translated to Korean.Locale::Kotocrates/tui/src/localization.rs(enum variant, tag, display name,all()/onboarding lists, translated helper strings,parse_locale, test locale-file mapping).Locale::Komatch arms incrates/tui/src/tui/setup/mod.rsfor the guided constitution/onboarding wizard (freeform principle, evidence, communication style, privacy, autonomy, authority, ratification preview, and related test fixtures) — purely additive, mirroring the existing per-language arms with no changes to shared logic.Locale::Koarms tocrates/tui/src/commands/groups/config/config.rs(locale tag display) andcrates/tui/src/commands/groups/debug/change.rs(locale display name).'9', "ko", "한국어", "(Korean)") tocrates/tui/src/tui/onboarding/language.rs.OnboardLanguageFooterin all six existing locale files (en, es-419, ja, pt-BR, vi, zh-Hans) from "Press 1-8" to "Press 1-9" since the onboarding language picker now has 9 options.Testing
cargo check -p codewhale-tui --lockedpasses clean.ko.jsonhas exactly the same 752 leaf keys asen.json(0 missing, 0 extra).