fix(skills): preserve inline task text#4372
Merged
Hmbown merged 1 commit intoJul 15, 2026
Merged
Conversation
Carry trailing arguments from $skill, direct slash skill invocations, and /skill <name> into the same queued message while preserving bare activation for the next turn. Keep /skill install reserved for skill management and cover exact-name install skills plus busy queue delivery. Fixes Hmbown#3915 Co-authored-by: Fushimi Rio <158128433+CCChisato@users.noreply.github.com> Signed-off-by: Nightt <87569709+nightt5879@users.noreply.github.com>
Contributor
Author
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Owner
|
Thank you, @nightt5879 and @CCChisato — merged for v0.8.68 with the original commit and co-author credit preserved. The release candidate keeps the additional queue-delivery regression and records both contributors in the release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$<skill> do X,/<skill> do X, and/skill <skill> do X$<skill>activation armed for the next user message/skill installas the management command while allowing a literalinstallskill through$install ...and/install ...Root cause
The unified skill command path accepted trailing arguments but discarded them before activation. The
/skill <name> <task>path also treated the whole raw argument string as the skill name, so it could not both select the skill and dispatch the task.Impact
Inline skill invocations now behave as a single request instead of silently dropping the user's task. Existing bare activation and skill-management behavior remain compatible.
Validation
cargo fmt --all -- --checkcargo test -p codewhale-tui --bin codewhale-tui --locked commands::groups::skills::skills::tests -- --test-threads=1(27 passed)cargo test -p codewhale-tui --bin codewhale-tui --locked inline_skill_request_keeps_instruction_when_busy_queueing -- --test-threads=1(1 passed)cargo clippy --workspace --all-features --locked -- -D warnings ...passedcargo test --workspace --all-features --lockedreached 6667 passed / 3 parallel-state failures; all three failures passed individually with--test-threads=1cargo build --release --locked -p codewhale-cli -p codewhale-tui; both binaries start and report version 0.8.68Closes #3915