Merge pull request #22396 from Homebrew/bundle-vscode-extension-filter

bundle: filter VSCode server chatter

Author: MikeMcQuaid

Library/Homebrew/bundle/extensions/vscode_extension.rb

@@ -9,6 +9,7 @@ class VscodeExtension < Extension
       PACKAGE_TYPE = :vscode
       PACKAGE_TYPE_NAME = "VSCode Extension"
       BANNER_NAME = "VSCode (and forks/variants) extensions"
+      EXTENSION_ID_REGEX = /\A[a-z0-9][a-z0-9-]*\.[a-z0-9][a-z0-9._-]*\z/i
 
       class << self
         sig { override.void }
@@ -46,7 +47,7 @@ def extensions
             Bundle.exchange_uid_if_needed! do
               ENV["WSL_DISTRO_NAME"] = ENV.fetch("HOMEBREW_WSL_DISTRO_NAME", nil)
               `"#{vscode}" --list-extensions 2>/dev/null`
-            end.split("\n").map(&:downcase)
+            end.split("\n").map(&:strip).grep(EXTENSION_ID_REGEX).map(&:downcase)
           end
           return [] if @extensions.nil?
 

Library/Homebrew/test/bundle/vscode_extension_spec.rb

@@ -48,6 +48,21 @@
           "tamasfe.even-better-toml",
         ])
       end
+
+      it "ignores VSCode server setup output" do
+        output = <<~EOF
+          updating vs code server to version f6cfa2ea2403534de03f069bdf160d06451ed282
+          downloading:     \b\b\b\b  0%\b\b\b\b100%
+          unpacked 3485 files and folders to /home/mike/.vscode-server/bin/f6cfa2ea2403534de03f069bdf160d06451ed282.
+          GitHub.codespaces
+        EOF
+
+        allow(klass).to receive(:`)
+          .with('"code" --list-extensions 2>/dev/null')
+          .and_return(output)
+
+        expect(dumper.extensions).to eql(["github.codespaces"])
+      end
     end
   end