Replace brew which-update

- Keep `brew which-update` as the CI-facing incremental command for
  command-not-found database entries.
- Remove the scheduled updater workflow and old bulk scan flags because
  core CI now updates touched formulae.
- Reuse `executables_db.rb` for versionless database writes and bottle
  metadata updates.
- Regenerate command docs, completions and Sorbet RBI for the new command
  interface.

Author: MikeMcQuaid

.github/workflows/command-not-found-db-update.yml

@@ -6,6 +6,7 @@
 
 require "abstract_command"
 require "executables_db"
+require "utils/github"
 
 module Homebrew
   module DevCmd
@@ -19,20 +20,23 @@ class WhichUpdate < AbstractCommand
                             "list of missing formulae)."
         switch "--commit",
                description: "Commit the changes using `git`."
-        switch "--update-existing",
-               description: "Update database entries with outdated formula versions."
-        switch "--install-missing",
-               description: "Install and update formulae that are missing from the database and don't have bottles."
-        switch "--eval-all",
-               description: "Evaluate all installed taps, rather than just the core tap."
-        flag   "--max-downloads=",
-               description: "Specify a maximum number of formulae to download and update."
+        flag   "--bottle-json-dir=",
+               description: "Use generated bottle JSON files in the given directory to update formula entries."
+        flag   "--formulae-file=",
+               description: "Update database entries for formulae listed in the given file."
+        flag   "--removed-formulae-file=",
+               description: "Remove database entries for formulae listed in the given file."
+        flag   "--pull-request=",
+               description: "Update entries for formula changes in the given pull request number."
+        flag   "--repository=",
+               description: "GitHub repository for `--pull-request` (default: `$GITHUB_REPOSITORY`)."
         flag   "--summary-file=",
                description: "Output a summary of the changes to a file."
         conflicts "--stats", "--commit"
-        conflicts "--stats", "--install-missing"
-        conflicts "--stats", "--update-existing"
-        conflicts "--stats", "--max-downloads"
+        conflicts "--stats", "--bottle-json-dir"
+        conflicts "--stats", "--formulae-file"
+        conflicts "--stats", "--removed-formulae-file"
+        conflicts "--stats", "--pull-request"
         named_args :database, number: 1
       end
 
@@ -41,13 +45,18 @@ def run
         if args.stats?
           stats source: args.named.fetch(0)
         else
-          update_and_save! source:          args.named.fetch(0),
-                           commit:          args.commit?,
-                           update_existing: args.update_existing?,
-                           install_missing: args.install_missing?,
-                           max_downloads:   args.max_downloads&.to_i,
-                           eval_all:        args.eval_all?,
-                           summary_file:    args.summary_file
+          updated = update_and_save! source:                args.named.fetch(0),
+                                     commit:                args.commit?,
+                                     bottle_json_dir:       args.bottle_json_dir,
+                                     formulae_file:         args.formulae_file,
+                                     removed_formulae_file: args.removed_formulae_file,
+                                     pull_request:          args.pull_request,
+                                     repository:            args.repository,
+                                     summary_file:          args.summary_file
+
+          if (github_output = ENV["GITHUB_OUTPUT"].presence)
+            File.open(github_output, "a") { |file| file.puts "updated=#{updated}" }
+          end
         end
       end
 
@@ -77,20 +86,54 @@ def stats(source:)
 
       sig {
         params(
-          source:          String,
-          commit:          T::Boolean,
-          update_existing: T::Boolean,
-          install_missing: T::Boolean,
-          max_downloads:   T.nilable(Integer),
-          eval_all:        T::Boolean,
-          summary_file:    T.nilable(String),
-        ).void
+          source:                String,
+          commit:                T::Boolean,
+          bottle_json_dir:       T.nilable(String),
+          formulae_file:         T.nilable(String),
+          removed_formulae_file: T.nilable(String),
+          pull_request:          T.nilable(String),
+          repository:            T.nilable(String),
+          summary_file:          T.nilable(String),
+        ).returns(T::Boolean)
       }
-      def update_and_save!(source:, commit: false, update_existing: false, install_missing: false,
-                           max_downloads: nil, eval_all: false, summary_file: nil)
+      def update_and_save!(source:, commit: false, bottle_json_dir: nil, formulae_file: nil,
+                           removed_formulae_file: nil, pull_request: nil, repository: nil, summary_file: nil)
+        source_path = Pathname(source)
+        original_database = source_path.exist? ? source_path.read : nil
         db = ExecutablesDB.new source
-        db.update!(update_existing:, install_missing:,
-                   max_downloads:, eval_all:)
+
+        formulae = file_lines(formulae_file).map { |name| File.basename(name, ".rb") }
+        removed_formulae = file_lines(removed_formulae_file).map { |name| File.basename(name, ".rb") }
+
+        if pull_request
+          repository = repository.presence || ENV["GITHUB_REPOSITORY"].presence
+          if repository.blank?
+            raise UsageError,
+                  "`--repository` or `$GITHUB_REPOSITORY` is required with `--pull-request`."
+          end
+
+          owner, repo = repository.split("/", 2)
+          raise UsageError, "`--repository` must be in the form `owner/repo`." if owner.blank? || repo.blank?
+
+          GitHub::API.paginate_rest(GitHub.url_to("repos", owner, repo, "pulls", pull_request, "files")) do |files|
+            T.cast(files, T::Array[T::Hash[String, T.untyped]]).each do |file|
+              filename = file["filename"].to_s
+              next if !filename.start_with?("Formula/") || !filename.end_with?(".rb")
+
+              case file["status"].to_s
+              when "removed"
+                removed_formulae << File.basename(filename, ".rb")
+              when "renamed"
+                removed_formulae << File.basename(file["previous_filename"].to_s, ".rb")
+                formulae << File.basename(filename, ".rb")
+              else
+                formulae << File.basename(filename, ".rb")
+              end
+            end
+          end
+        end
+
+        db.update!(bottle_json_dir:, formulae:, removed_formulae:)
         db.save!
 
         if summary_file
@@ -100,10 +143,11 @@ def update_and_save!(source:, commit: false, update_existing: false, install_mis
           end
         end
 
-        return if !commit || !db.changed?
+        return original_database != source_path.read if !commit || !db.changed?
 
         msg = git_commit_message(db.changes)
         safe_system "git", "-C", db.root.to_s, "commit", "-m", msg, source
+        original_database != source_path.read
       end
 
       sig { params(els: T::Array[String], verb: String).returns(String) }
@@ -121,7 +165,6 @@ def git_commit_message(changes)
           names = changes.send(action)
           next if names.empty?
 
-          action = "bump version for" if action == :version_bump
           msg << english_list(names.to_a.sort, action.to_s)
           break
         end
@@ -152,6 +195,17 @@ def summary_file_message(changes)
           #{msg.join("\n")}
         MESSAGE
       end
+
+      private
+
+      sig { params(path: T.nilable(String)).returns(T::Array[String]) }
+      def file_lines(path)
+        return [] if path.blank? || !File.file?(path)
+
+        File.readlines(path, chomp: true).filter_map do |line|
+          line.strip.presence
+        end
+      end
     end
   end
 end