Avoid install warning annotations

- Keep idempotent `brew install` warnings visible in CI logs.
- Avoid noisy GitHub Actions annotations for harmless installs.
- Preserve annotation behaviour for other `opoo` callers.

Author: MikeMcQuaid

Library/Homebrew/install.rb

@@ -147,7 +147,7 @@ def install_formula?(
           elsif only_dependencies
             return true
           elsif !quiet
-            opoo <<~EOS
+            opoo_without_github_actions_annotation <<~EOS
               #{formula.full_name} #{formula.pkg_version} is already installed and up-to-date.
               To reinstall #{formula.pkg_version}, run:
                 brew reinstall #{formula.name}
@@ -185,15 +185,14 @@ def install_formula?(
                 brew link #{formula.full_name}
             EOS
           else
-            msg = if quiet
-              nil
-            else
-              <<~EOS
+            unless quiet
+              opoo_without_github_actions_annotation <<~EOS
                 #{msg} and up-to-date.
                 To reinstall #{formula.pkg_version}, run:
                   brew reinstall #{formula.name}
               EOS
             end
+            msg = nil
           end
           opoo msg if msg
         elsif !formula.any_version_installed? && (old_formula = formula.old_installed_formulae.first)

Library/Homebrew/test/utils/output_spec.rb

@@ -2,6 +2,7 @@
 # frozen_string_literal: true
 
 require "utils/output"
+require "utils/github/actions"
 
 RSpec.describe Utils::Output do
   let(:klass) { Utils::Output }
@@ -136,6 +137,18 @@ def esc(code)
     end
   end
 
+  describe "#opoo_without_github_actions_annotation" do
+    it "prints a warning without a GitHub Actions annotation" do
+      with_env(GITHUB_ACTIONS: "true") do
+        expect(GitHub::Actions).not_to receive(:puts_annotation_if_env_set!)
+
+        expect do
+          klass.opoo_without_github_actions_annotation "foo"
+        end.to output("Warning: foo\n").to_stderr
+      end
+    end
+  end
+
   describe "#odie" do
     it "exits with 1" do
       expect do

Library/Homebrew/utils/output.rb

@@ -76,6 +76,18 @@ def opoo(message)
         end
       end
 
+      sig { params(message: T.any(String, Exception)).void }
+      def opoo_without_github_actions_annotation(message)
+        require "utils/github/actions"
+        return opoo(message) unless GitHub::Actions.env_set?
+
+        require "utils/formatter"
+
+        Tty.with($stderr) do |stderr|
+          stderr.puts Formatter.warning(message, label: "Warning")
+        end
+      end
+
       # Print a warning message only if not running in GitHub Actions.
       #
       # @api public