Merge pull request #22317 from HaraldNordgren/file-url-basename

parse_basename: fix local test failures

Author: MikeMcQuaid

Library/Homebrew/download_strategy/abstract_file_download_strategy.rb

@@ -82,8 +82,10 @@ def resolved_url_and_basename
   def parse_basename(url, search_query: true)
     components = { path: T.let([], T::Array[String]), query: T.let([], T::Array[String]) }
 
+    file_url = T.let(false, T::Boolean)
     if url.match?(URI::RFC2396_PARSER.make_regexp)
       uri = URI(url)
+      file_url = uri.scheme == "file"
 
       if (uri_query = uri.query.presence)
         URI.decode_www_form(uri_query).each do |key, param|
@@ -109,9 +111,13 @@ def parse_basename(url, search_query: true)
     # extensions (e.g. tar.gz).
     # Given a URL like https://example.com/download.php?file=foo-1.0.tar.gz
     # the basename we want is "foo-1.0.tar.gz", not "download.php".
-    [*components[:path], *components[:query]].reverse_each do |path|
-      path = Pathname(path)
-      return path.basename.to_s if path.extname.present?
+    # Skipped for file:// URLs since their paths can contain ancestor
+    # directories with dots (e.g. "github.com") that aren't real extensions.
+    unless file_url
+      [*components[:path], *components[:query]].reverse_each do |path|
+        path = Pathname(path)
+        return path.basename.to_s if path.extname.present?
+      end
     end
 
     filename = components[:path].last

Library/Homebrew/test/download_strategies/abstract_file_spec.rb

@@ -0,0 +1,39 @@
+# typed: false
+# frozen_string_literal: true
+
+require "download_strategy"
+
+RSpec.describe AbstractFileDownloadStrategy do
+  subject(:strategy) { Class.new(described_class).new(url, "foo", "1.2.3") }
+
+  let(:url) { "https://example.com/foo.tar.gz" }
+
+  describe "#parse_basename" do
+    it "returns the final path segment for simple URLs" do
+      expect(strategy.send(:parse_basename, "https://example.com/foo.tar.gz")).to eq("foo.tar.gz")
+    end
+
+    it "prefers a path segment with an extension over later extensionless segments" do
+      expect(strategy.send(:parse_basename, "https://example.com/foo-1.0.tar.gz/download")).to eq("foo-1.0.tar.gz")
+    end
+
+    it "extracts the basename from a response-content-disposition query parameter" do
+      url = "https://example.com/download.php?file=ignored&response-content-disposition=attachment;filename=\"real.tar.gz\""
+      expect(strategy.send(:parse_basename, url)).to eq("real.tar.gz")
+    end
+
+    it "uses the query value when the path has no extension" do
+      url = "https://example.com/download.php?file=foo-1.0.tar.gz"
+      expect(strategy.send(:parse_basename, url)).to eq("foo-1.0.tar.gz")
+    end
+
+    it "returns the final segment for file:// URLs even when an ancestor directory contains a dot" do
+      expect(strategy.send(:parse_basename, "file:///Users/me/git-repos/github.com/Homebrew/brew/naked_executable"))
+        .to eq("naked_executable")
+    end
+
+    it "returns the final segment for file:// URLs with an extension" do
+      expect(strategy.send(:parse_basename, "file:///tmp/foo.tar.gz")).to eq("foo.tar.gz")
+    end
+  end
+end